Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock publish pipeline by excluding native libraries in android builds #875

Closed
wants to merge 1 commit into from
Closed

Unblock publish pipeline by excluding native libraries in android builds #875

wants to merge 1 commit into from

Conversation

mganandraj
Copy link

Unblock publish pipeline by excluding native libraries in android builds
It's fine as Office don't consume android libraries from the npm package.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Unblock publish pipeline by excluding native libraries in android builds

Changelog

Unblock publish pipeline by excluding native libraries in android builds

[CATEGORY] [TYPE] - Message

@mganandraj
Unblock publish pipeline by excluding native libraries in android builds
c2289d7 
It's fine as Office don't consume android libraries from the npm package.
@mganandraj mganandraj requested a review from alloy as a code owner October 28, 2021 18:19
@mganandraj mganandraj requested a review from acoates-ms October 28, 2021 18:19
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against c2289d7

acoates-ms added a commit to acoates-ms/react-native that referenced this pull request Oct 28, 2021
@acoates-ms
Apply microsoft#875
573f6b3
@acoates-ms
Copy link
Collaborator

This fix included in #866.

@acoates-ms acoates-ms closed this Oct 28, 2021
acoates-ms added a commit that referenced this pull request Oct 28, 2021
@acoates-ms @mganandraj
@msgharpu @tido64
[0.64] Fix publish builds by removing workspace from package.json bef…
1dc7d83 
…ore publish (#866)

* Some more changes for bringing up RN64 in devmain Android (#861)

* Build & Packaging changes for bringing up RN64 in devmain

* Fixing gradle clean

* Disable gradle clean in PR builds

* Fix for submit button disappearing bug in comments (#862)

* Add the missing android folder to files in package.json

* Fix for submit button disappear bug in comments

Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com>

* fix: ensure scripts always have Unix newlines (#860)

* Fix for publishing from stable branches

* remove workspace info before publishing too

* Update rntester lock file when bumping package version

* Apply #875

* Allow newer cocoapod version

Co-authored-by: Anandraj <anandrag@microsoft.com>
Co-authored-by: Mayuresh Gharpure <gharpuremayuresh@gmail.com>
Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeyImChris HeyImChris HeyImChris approved these changes

@alloy alloy Awaiting requested review from alloy alloy is a code owner

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mganandraj @pull-bot @acoates-ms @HeyImChris