fix(android) Be more explicit about which gradle plugin to include #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
|
hey @johnf one quick headsup, you are missing the |
kelset
approved these changes
Mar 25, 2024
Contributor
kelset
left a comment
kelset
left a comment
There was a problem hiding this comment.
aside from the commit lint issue, the change is solid and respect existing approch, LGTM 👍
one small nit is that I'm not sure we'd recommend having multiple RNTA apps in the same codebase on different RN versions, but we can explore more that conversation here (#1932)
The previous approach could fail in a monorepo where both modules could exist in a hoisted node_modules
Contributor
Author
|
fixed |
tido64
approved these changes
Mar 25, 2024
Member
|
@johnf, this is a good fix. Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach could fail in a monorepo where both modules could exist in a hoisted node_modules
Description
I discovered an issue with selecting which version of the react native module to include.
The current code checks if
@react-native/gradle-pluginexists (RN >= 0.72) and usesit if it does.This logic fails in a monorepo situation where both libraries could exist for different packages.
This change explicitly checks the react native version and loas the appropriate library.
This is on the path to helping me solve #1932
Platforms affected
Test plan
I'm currently testing this against my code base. Easiest way to reproduce