From c27ba73117f0ac25528277fd0c4361126d015d15 Mon Sep 17 00:00:00 2001 From: Vinutha Karanth Date: Wed, 13 Apr 2022 17:26:34 -0700 Subject: [PATCH] All component title and descriptions should be aligned (#1346) * update Signed-off-by: vinutha karanth * lintfix Signed-off-by: vinutha karanth --- .../describer/modelAssessment/Constants.ts | 2 +- .../CausalInsights.styles.ts | 2 +- .../CausalAggregateView.tsx | 6 ++++- .../CausalIndividualView.tsx | 6 ++++- .../TreatmentBarChartSection.tsx | 2 +- .../TreatmentView/TreatmentListSection.tsx | 4 +-- .../TreatmentView/TreatmentStyles.ts | 1 - .../TreatmentView/TreatmentTable.styles.ts | 1 - .../TreatmentView/TreatmentTableSection.tsx | 2 +- .../TreatmentView/TreatmentView.tsx | 7 ++++- .../src/lib/LocalImportanceChart.tsx | 2 +- .../src/lib/DatasetExplorerTab.styles.ts | 6 ++--- .../src/lib/DatasetExplorerTab.tsx | 26 ++++++++++--------- .../ErrorAnalysisView/ErrorAnalysis.styles.ts | 2 ++ .../ErrorAnalysisViewTab.tsx | 2 +- .../GlobalExplanationTab.styles.ts | 2 ++ .../WhatIfTab/LocalImportancePlots.tsx | 2 +- .../Controls/WhatIfTab/WhatIfTab.styles.ts | 2 ++ .../IndividualFeatureImportanceView.styles.ts | 7 +++-- .../IndividualFeatureImportanceView.tsx | 2 +- 20 files changed, 53 insertions(+), 33 deletions(-) diff --git a/apps/widget-e2e/src/describer/modelAssessment/Constants.ts b/apps/widget-e2e/src/describer/modelAssessment/Constants.ts index 8af1a25d33..555265d38c 100644 --- a/apps/widget-e2e/src/describer/modelAssessment/Constants.ts +++ b/apps/widget-e2e/src/describer/modelAssessment/Constants.ts @@ -11,7 +11,7 @@ export enum Locators { IFIExpandCollapseButton = "[aria-label='expand collapse group']", IFITableRowSelected = 'div[class^="ms-List-page"] div[class^="ms-DetailsRow"] div[class^="ms-Check is-checked"]', IFIDropdownSelectedOption = "div[class^='featureImportanceChartAndLegend']", - IFIScrollableTable = "div.tabularDataView div.ms-ScrollablePane div.ms-ScrollablePane--contentContainer", + IFIScrollableTable = "div[class*='tabularDataView'] div.ms-ScrollablePane div.ms-ScrollablePane--contentContainer", IFINumberOfBars = "#FeatureImportanceBar svg g.highcharts-series-group rect", IFIYAxisValue = '#FeatureImportanceBar div[class^="rotatedVerticalBox-"]', IFIXAxisValue = "#FeatureImportanceBar g.highcharts-xaxis-labels text", diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/CausalInsights.styles.ts b/libs/causality/src/lib/CausalAnalysisDashboard/CausalInsights.styles.ts index cca90386f9..1ee3b3121e 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/CausalInsights.styles.ts +++ b/libs/causality/src/lib/CausalAnalysisDashboard/CausalInsights.styles.ts @@ -18,7 +18,7 @@ export const causalInsightsStyles: () => IProcessedStyleSet({ container: { color: theme.semanticColors.bodyText, - padding: "0 40px 10px 20px" + padding: "0 40px 10px 40px" } }); }; diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalAggregateView/CausalAggregateView.tsx b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalAggregateView/CausalAggregateView.tsx index 5ea40dfccc..484a343d00 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalAggregateView/CausalAggregateView.tsx +++ b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalAggregateView/CausalAggregateView.tsx @@ -30,7 +30,11 @@ export class CausalAggregateView extends React.PureComponent d2.point - d1.point); return ( - + diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalIndividualView/CausalIndividualView.tsx b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalIndividualView/CausalIndividualView.tsx index c3fb353e35..ea72efa648 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalIndividualView/CausalIndividualView.tsx +++ b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/CausalIndividualView/CausalIndividualView.tsx @@ -44,7 +44,11 @@ export class CausalIndividualView extends React.PureComponent< public render(): React.ReactNode { const styles = CausalIndividualStyles(); return ( - + {localization.CausalAnalysis.IndividualView.description} diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentBarChartSection.tsx b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentBarChartSection.tsx index 6b6ea727a9..16c812499b 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentBarChartSection.tsx +++ b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentBarChartSection.tsx @@ -29,7 +29,7 @@ export class TreatmentBarChartSection extends React.PureComponent + {this.props.data?.policy_gains ? ( + - + diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentStyles.ts b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentStyles.ts index 7621d3567d..f82f24a14a 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentStyles.ts +++ b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentStyles.ts @@ -41,7 +41,6 @@ export const TreatmentStyles: () => IProcessedStyleSet = }, header: { fontSize: 14, - margin: "20px", maxWidth: descriptionMaxWidth, textAlign: "left" }, diff --git a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentTable.styles.ts b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentTable.styles.ts index 1b199481ee..c5a72a9298 100644 --- a/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentTable.styles.ts +++ b/libs/causality/src/lib/CausalAnalysisDashboard/Controls/CausalAnalysisView/TreatmentView/TreatmentTable.styles.ts @@ -36,7 +36,6 @@ export const TreatmentTableStyles: () => IProcessedStyleSet{localization.CausalAnalysis.TreatmentPolicy.noData}; } return ( - +