Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] "rush add" does not install package with npm #1013

Open
cortopy opened this issue Jan 9, 2019 · 8 comments
Open

[rush] "rush add" does not install package with npm #1013

cortopy opened this issue Jan 9, 2019 · 8 comments
Labels
needs more info We can't proceed because we need a better repro or an answer to a question

Comments

@cortopy
Copy link

cortopy commented Jan 9, 2019

Folllowing discussion in #991, I've done further testing with npm and I'm experiencing a separate issue with rush add

If I do rush add -p <package>, rush runs update. However, that is not enough to make the package available.

After each rush add I have to do rush update --full. Otherwise, it doesn't work

@octogonz
Copy link
Collaborator

octogonz commented Jan 9, 2019

@cortopy is this issue a duplicate of #886 ?

@octogonz octogonz added the needs more info We can't proceed because we need a better repro or an answer to a question label Jan 9, 2019
@cortopy
Copy link
Author

cortopy commented Jan 10, 2019

@pgonzal not sure. This behaviour is not listed in that list and npm is working fine for me. I don't have an issue with npm itself.

It just feels either:

@RichiCoder1
Copy link

Been running into this same issue to. Would rush add -p some-package, do a rush build, rush test, and get complains about some-package not being available. Then have to rush update --full or rush update --full -p to get my package reflected.

@octogonz octogonz changed the title rush add does not install package with npm [rush] "rush add" does not install package with npm May 13, 2019
@octogonz
Copy link
Collaborator

octogonz commented May 13, 2019

This sounds like a problem with rush update, and only indirectly related to rush add.

Could you try:

  1. Manually add a dependency to your package.json
  2. Run rush update and see if the problem repros

If it does repro, could you repeat the above steps using NPM 4.5.0? There are known problems with other newer releases of NPM detailed here. If this turns out to be a dupe of one of those symptoms, that issue already documents the next steps for fixing it (which have not been pursued because Rush users always seem to move to PNPM or Yarn).

@efitzkiwi
Copy link

Still having this problem almost 2022

@Dartv
Copy link

Dartv commented Jan 13, 2023

2023 and this is still an issue. Only rush update --full works.

@zyrorl
Copy link

zyrorl commented Apr 26, 2023

I can't believe this is still a problem... it's April 2023... still broken.

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Feb 26, 2024
@tbenyon
Copy link

tbenyon commented Jun 4, 2024

I'm also seeing this problem. I found the only thing that worked was rush update --full -p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info We can't proceed because we need a better repro or an answer to a question
Projects
Status: Needs triage
Development

No branches or pull requests

7 participants