Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-core-library] Add support for alreadyExistsBehavior for symlinks and junctions #2884

Merged
merged 10 commits into from
Sep 11, 2021
Merged

[node-core-library] Add support for alreadyExistsBehavior for symlinks and junctions #2884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f3ae1f3
Add support for alreadyExistsBehavior for symlinks and junctions
D4N14L Sep 1, 2021
bd8981d
Rush change
D4N14L Sep 1, 2021
1bc9a7b
Break instead of return
D4N14L Sep 1, 2021
9be1304
PR feedback and interface changes
D4N14L Sep 2, 2021
ea84938
Clarify overwrite behavior on comment
D4N14L Sep 2, 2021
399b206
Update comment in sync method
D4N14L Sep 2, 2021
0203351
Merge branch 'master' of https://github.com/microsoft/rushstack into …
D4N14L Sep 11, 2021
6af2767
Update to discussed behaviour of AlreadyExistsBehavior.Overwrite
D4N14L Sep 11, 2021
a920a74
Include api doc changes
D4N14L Sep 11, 2021
cf3e4bd
Improve docs
octogonz Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...n/changes/@rushstack/node-core-library/user-danade-FixAlreadyExists_2021-09-01-23-31.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@rushstack/node-core-library",
"comment": "Add support for AlreadyExistsBehavior in symlink and junction scenarios",
"type": "patch"
}
],
"packageName": "@rushstack/node-core-library",
"email": "3473356+D4N14L@users.noreply.github.com"
}
2 changes: 2 additions & 0 deletions common/reviews/api/node-core-library.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,11 @@ export class FileSystem {
static getStatistics(path: string): FileSystemStats;
static getStatisticsAsync(path: string): Promise<FileSystemStats>;
static isErrnoException(error: Error): error is NodeJS.ErrnoException;
static isExistError(error: Error): boolean;
static isFileDoesNotExistError(error: Error): boolean;
static isFolderDoesNotExistError(error: Error): boolean;
static isNotExistError(error: Error): boolean;
static isUnlinkNotPermittedError(error: Error): boolean;
static move(options: IFileSystemMoveOptions): void;
static moveAsync(options: IFileSystemMoveOptions): Promise<void>;
static readFile(filePath: string, options?: IFileSystemReadFileOptions): string;
Expand Down
Loading