Redesign the PackageJsonLookup API #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… definition is now removed
iclanton
reviewed
Mar 16, 2018
| + 'The required field "version" was not found'); | ||
| } | ||
|
|
||
| if (this._loadExtraFields) { |
There was a problem hiding this comment.
_loadExtraFields [](start = 15, length = 16)
What about an optional parameter that lets you list out properties that you want? #WontFix
There was a problem hiding this comment.
It's a good idea, but I'd like to wait until someone really needs it before designing it.
In reply to: 175201618 [](ancestors = 175201618)
|
Skipped Travis build because Travis is experiencing an outage |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for PackageJsonLookup, which clarifies the API names, and expands the cache to store individual package.json fields beyond just the package name.
Rush's IPackageJson interface is promoted to be part of node-core-library.