diff --git a/src/Sarif/Visitors/GitHubIngestionVisitor.cs b/src/Sarif/Visitors/GitHubIngestionVisitor.cs index d5b11ddce..341385fb4 100644 --- a/src/Sarif/Visitors/GitHubIngestionVisitor.cs +++ b/src/Sarif/Visitors/GitHubIngestionVisitor.cs @@ -20,14 +20,6 @@ public override Run VisitRun(Run node) this.artifacts = node.Artifacts; this.threadFlowLocations = node.ThreadFlowLocations; - // GitHub does not support submitting invocation objects. Invocations - // contains potentially sensitive environment details, such as - // account names embedded in paths. Invocations also store - // notifications of catastrophic tool failures, however, which - // means there is current no mechanism for reporting these to - // GitHub users in context of the security tab. - node.Invocations = null; - if (node.Results != null) { int errorsCount = 0; diff --git a/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj b/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj index 002bb2f52..dacdeb925 100644 --- a/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj +++ b/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj @@ -22,13 +22,11 @@ - - @@ -91,13 +89,11 @@ - - diff --git a/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/ExpectedOutputs/WithInvocation.sarif b/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/ExpectedOutputs/WithInvocation.sarif deleted file mode 100644 index 0e94c720b..000000000 --- a/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/ExpectedOutputs/WithInvocation.sarif +++ /dev/null @@ -1,22 +0,0 @@ -{ - "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", - "version": "2.1.0", - "runs": [ - { - "tool": { - "driver": { - "name": "Sarif.UnitTests" - } - }, - "results": [ - { - "ruleId": "TEST1001", - "level": "error", - "message": { - "text": "The message." - } - } - ] - } - ] -} \ No newline at end of file diff --git a/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/Inputs/WithInvocation.sarif b/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/Inputs/WithInvocation.sarif deleted file mode 100644 index 8678051da..000000000 --- a/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/Inputs/WithInvocation.sarif +++ /dev/null @@ -1,27 +0,0 @@ -{ - "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json", - "version": "2.1.0", - "runs": [ - { - "tool": { - "driver": { - "name": "Sarif.UnitTests" - } - }, - "invocations": [ - { - "executionSuccessful": true - } - ], - "results": [ - { - "ruleId": "TEST1001", - "level": "error", - "message": { - "text": "The message." - } - } - ] - } - ] -} \ No newline at end of file diff --git a/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs b/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs index 8db686a15..73df73664 100644 --- a/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs +++ b/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs @@ -42,10 +42,6 @@ public void GitHubDspIngestionVisitor_LimitsNumberOfResults() } } - [Fact] - public void GitHubDspIngestionVisitor_RemovesInvocations() - => RunTest("WithInvocation.sarif"); - [Fact] public void GitHubDspIngestionVisitor_RemovesArtifactsAndRetainsIndirectArtifactLocations() => RunTest("WithArtifacts.sarif");