From af69a1892954eb920c2a7e7b28e23effe35903c3 Mon Sep 17 00:00:00 2001 From: "Michael C. Fanning" Date: Mon, 12 Sep 2022 16:59:59 -0700 Subject: [PATCH] Insert optional data visitor file regions cache (#2544) * Allow per-instance file regions cache to be set on InsertOptionalDataVisitor. * Provide context region construction helper in 'FileRegionsCache'. --- src/ReleaseHistory.md | 1 + src/Sarif/FileRegionsCache.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ReleaseHistory.md b/src/ReleaseHistory.md index 463fde997..70d563727 100644 --- a/src/ReleaseHistory.md +++ b/src/ReleaseHistory.md @@ -1,5 +1,6 @@ # SARIF Package Release History (SDK, Driver, Converters, and Multitool) +## Unreleased * FEATURE: Allow initialization of file regions cache in `InsertOptionalDataVisitor` (previously initialized exclusively from `FileRegionsCache.Instance`). * BUGFIX: Resolve issue where `match-results-forward` command fails to generate VersionControlDetails data. [#2487](https://github.com/microsoft/sarif-sdk/pull/2487) * BUGFIX: Remove duplicated rule definitions when executing `match-results-forward` commands for results with sub-rule ids. [#2486](https://github.com/microsoft/sarif-sdk/pull/2486) diff --git a/src/Sarif/FileRegionsCache.cs b/src/Sarif/FileRegionsCache.cs index 57e2f1421..e6aac08bf 100644 --- a/src/Sarif/FileRegionsCache.cs +++ b/src/Sarif/FileRegionsCache.cs @@ -142,7 +142,7 @@ private Region PopulateTextRegionProperties(NewLineIndex lineIndex, Region input return region; } - internal Region ConstructMultilineContextSnippet(Region inputRegion, Uri uri) + public Region ConstructMultilineContextSnippet(Region inputRegion, Uri uri) { if (inputRegion?.IsBinaryRegion != false) {