From da7d45c6d69f3f59e2d57706eed47cce43cd6a4c Mon Sep 17 00:00:00 2001
From: "Benjin Dubishar (from Dev Box)" <benjind@microsoft.com>
Date: Tue, 15 Oct 2024 14:04:18 -0700
Subject: [PATCH] Removing incorrect "attachedDBFileName" option.  The correct
 option already existed: "attachDbFileName" (no "ed")

---
 .../Connection/ConnectionProviderOptionsHelper.cs      | 10 +---------
 .../Localization/sr.resx                               |  2 +-
 .../Localization/sr.xlf                                |  4 ++--
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionProviderOptionsHelper.cs b/src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionProviderOptionsHelper.cs
index 627e172997..ddca1f5c1b 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionProviderOptionsHelper.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionProviderOptionsHelper.cs
@@ -189,14 +189,6 @@ internal static ConnectionProviderOptions BuildConnectionProviderOptions()
                         ValueType = ConnectionOption.ValueTypeString,
                     },
                     new ConnectionOption
-                    {
-                        Name = "attachedDBFileName",
-                        DisplayName = SR.ConnectionConfigOptions_attachedDBFileName_displayName,
-                        Description = SR.ConnectionConfigOptions_attachedDBFileName_description,
-                        ValueType = ConnectionOption.ValueTypeString,
-                        GroupName = SR.ConnectionConfigOptions_groups_context
-                    },
-                    new ConnectionOption
                     {
                         Name = "contextConnection",
                         DisplayName = SR.ConnectionConfigOptions_contextConnection_displayName,
@@ -292,7 +284,7 @@ internal static ConnectionProviderOptions BuildConnectionProviderOptions()
                         Name = "attachDbFilename",
                         DisplayName = SR.ConnectionConfigOptions_attachDbFilename_displayName,
                         ValueType = ConnectionOption.ValueTypeString,
-                        GroupName = "Source"
+                        GroupName = SR.ConnectionConfigOptions_groups_context
                     },
                     new ConnectionOption
                     {
diff --git a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
index a0485d8da3..d2c0d32b26 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
+++ b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
@@ -5506,7 +5506,7 @@ The Query Processor estimates that implementing the following index could improv
     <comment></comment>
   </data>
   <data name="ConnectionConfigOptions_connectTimeout_displayName" xml:space="preserve">
-    <value>Connect timeout</value>
+    <value>Connection timeout (seconds)</value>
     <comment></comment>
   </data>
   <data name="ConnectionConfigOptions_connectTimeout_description" xml:space="preserve">
diff --git a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
index 848889146f..09fef88fa5 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
+++ b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
@@ -88,8 +88,8 @@
         <note></note>
       </trans-unit>
       <trans-unit id="ConnectionConfigOptions_connectTimeout_displayName">
-        <source>Connect timeout</source>
-        <target state="new">Connect timeout</target>
+        <source>Connection timeout (seconds)</source>
+        <target state="new">Connection timeout (seconds)</target>
         <note></note>
       </trans-unit>
       <trans-unit id="ConnectionConfigOptions_commandTimeout_displayName">