-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SettingsUI: Add new ... StartingDirectory/Browse greyed out #10017
Comments
This sounds similar to #9847 (but that was fixed...), have you set the default directory under 'defaults' in your settings.json file? |
No, a default directory is not specified in 'defaults'. |
Hm I can't seem to repro this (I am on WT 1.9 though). Could you share what is in the 'profiles' section of your settings file? |
Sure (see below). Here's a bigger pic. Interesting: Inthe JSON file, I don't see "commandline" (or a GUID) for the "Hidden" profile (shown in the pic).
|
That is expected! When a profile in the settings file does not explicitly define a commandline, we give it a 'default' commandline, which is cmd (that is technically an oversimplification of the way we handle settings but the gist is there). |
I typed "cmd.exe" in the "Command line" field of the UI. It still doesn't appear in the JSON file. I changed it to c:\windows\system32\cmd.exe and it appeared in the JSON file. I changed it back to "cmd.exe". Now it appears as "cmd.exe" in the JSON file. And all the time, "Starting Directory" and "Browse" are greyed out. |
Hmmm! I use "Add new". "Cmd.exe" is automatically placed in the UI field but not in the JSON file. In the UI, I erase it and enter "cmd.exe"; it still does not go into the JSON file. In the UI, I change it to "s:\cmd.exe"; now it's in the JSON file. In the UI, I change it back to "cmd.exe"; now it's in the JSON file (the same string that wasn't in the JSON file in the first place). Isn't that a bit goofy? Can't it simply always go into the JSON file? And what about GUIDs? You don't get one with "Add new". Are GUIDs necessary, ever? |
Same for me:
|
Tipp: The workaround is editing json manually. Then the settings field for Directory is available. |
@zadjii-msft In my json only the guid (only auto-generated), path, icon and hide setting are existing for the profiles. |
Looks like this will be fixed in 1.13 when #11720 merges. Actually this looks like it is fixed in Stable as well, 1.11.3471. With great likelyhood, even before that too. |
I didn't realize this was not answered! We only include the modified (or required for ID) settings in your JSON -- otherwise, an autogenerated profile would be generated one time and we could never fix bugs in the profile generator. |
Forgive me if this has been addressed already somewhere else, but I realized that when |
Windows Terminal version (or Windows build number)
WindowsTerminal: 1.8.1092.0
Other Software
No response
Steps to reproduce
SettingsUI ... Add new ... uncheck "Use parent process directory"
Expected Behavior
Should be able to specify a starting directory.
Actual Behavior
The "Starting directory field and the "Browse" button are greyed out. That's also the case if you uncheck "Use parent process directory" for an existing profile with no starting directory specified.
The text was updated successfully, but these errors were encountered: