Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set keyboard shortcuts with non-printable characters #11921

Closed
VedresDavid opened this issue Dec 10, 2021 · 3 comments
Closed

Can't set keyboard shortcuts with non-printable characters #11921

VedresDavid opened this issue Dec 10, 2021 · 3 comments
Labels
Area-Settings UI Anything specific to the SUI Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@VedresDavid
Copy link

Windows Terminal version

1.11.2921.0

Windows build number

22000.318

Other Software

No response

Steps to reproduce

go to the actions tab and try to change one of the shortcuts to something else. for example i tried to set the quake mode to win + 0 but i can't record the win/alt/ctrl and other non-printable keys.

Expected Behavior

i want to be able to create shortcuts that contain special characters in them. (win/alt/ctrl...)

Actual Behavior

i can't

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 10, 2021
@zadjii-msft
Copy link
Member

win/alt/ctrl and other non-printable keys.

That's weird - are you just pressing the keybinding in the editor, or are you trying to type the key out? Might be related to #11341

FWIW, Win+1-Win+0 won't work as keybindings, since those are reserved by the OS.

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 13, 2021
@VedresDavid
Copy link
Author

i tried both typing it out and pressing the keys. neither of them worked. though the ctrl key started working so i just set the quake mode to ctrl + 0. the other keys still won't work. my guess is that the os is capturing the win key from the application.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 13, 2021
@zadjii-msft
Copy link
Member

my guess is that the os is capturing the win key from the application.

Could be. Depends on what key chord you're pressing - most of them are reserved by the OS. You could always edit the settings.json file by hand, to add the chord you want. I suspect, however, if it's not reaching the Terminal in the Settings UI, then something's already hooked that keybinding, and setting that keybinding manually won't work either 😉

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

2 participants