Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal > Export Text]: Keyboard only users do not have option to use 'Export text' functionality. #12052

Closed
Tracked by #9990
ghost opened this issue Dec 28, 2021 · 6 comments
Closed
Tracked by #9990

[Terminal > Export Text]: Keyboard only users do not have option to use 'Export text' functionality. #12052

ghost opened this issue Dec 28, 2021 · 6 comments
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.13

Comments

@ghost
Copy link

ghost commented Dec 28, 2021

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:
Open Windows Terminal.
Verify that keyboard only users can Export text or not.

User Experience:
Keyboard only users UX will not be good as they are not able to use a certain functionality.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/keyboard

Attachments:
Keyboard only users do not have option to use 'Export text' functionality..zip

Expected Behavior

Keyboard only users should be able to use 'Export text' functionality.

Actual Behavior

Keyboard only users does not have option to use 'Export text' functionality.
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev2 Accessibility tracking Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 28, 2021
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Jan 3, 2022
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jan 3, 2022
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jan 3, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 3, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H1 Jan 3, 2022
@zadjii-msft
Copy link
Member

@v-rpundir would it be sufficient to have an exportBuffer action which the user can bind to a keybinding for exporting the text? (As discussed in #9700, #11090)? They would still have access to the functionality, but via the command palette / keybindings instead of via the tab context menu.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 5, 2022
Merged
3 tasks
@ghost
Copy link
Author

ghost commented Jan 7, 2022 •
edited by ghost
Loading

@zadjii-msft Yup exportBuffer action will be sufficient for exporting the text, just like you have actions for 'Rename tab' or 'Duplicate tab' which is also present in tab context menu.

ghost pushed a commit that referenced this issue Jan 12, 2022
@zadjii-msft
Add an exportBuffer action (#12097)
862d8ed 
This adds an action for the context menu entry we added in #11062. That PR added support for exporting the buffer, exclusively through the tab item's context menu. This adds an action that can additionally be bound, which also can export the buffer to a file. This action accepts a `path` param. If empty/ommitted, then the Terminal will prompt for the file to export the buffer to. 

* Does a part of #9700
* Spec in #11090, but I doubt this is contentious
* [x] This will satisfy #12052
* [x] I work here
* [x] docs added: MicrosoftDocs/terminal#479
@zadjii-msft zadjii-msft mentioned this issue Jan 27, 2022
Open
12 tasks
@zadjii-msft zadjii-msft added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 27, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.13 Feb 2, 2022
@carlos-zamora
Copy link
Member

@v-rpundir This is now fixed in v1.13.10333.0 (Terminal Preview). Can you please confirm?

@ghost
Copy link
Author

ghost commented Feb 4, 2022

Hi @carlos-zamora the latest build I have is Terminal Preview 1.12.3472.0 so I will keep this work in my To-Do list for now and will check when mentioned build is available here.

It will be better if you can provide us mentioned build us to verify the same.

@zadjii-msft
Copy link
Member

@v-rpundir You can manually install the latest build using the .msixbundle from our Releases page here: https://github.com/microsoft/terminal/releases/tag/v1.13.10336.0

@ghost
Copy link
Author

ghost commented Feb 4, 2022

Closing as Export Actions is available now on Windows Terminal Preview Version: 1.13.10336.0

@ghost ghost closed this as completed Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.13
Development

No branches or pull requests
2 participants
@carlos-zamora @zadjii-msft