Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command buttons in settings view are in the wrong order #13174

Closed
danielchalmers opened this issue May 25, 2022 · 3 comments · Fixed by #13237
Closed

Command buttons in settings view are in the wrong order #13174

danielchalmers opened this issue May 25, 2022 · 3 comments · Fixed by #13237
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@danielchalmers
Copy link

danielchalmers commented May 25, 2022 •
edited
Loading

Windows Terminal version

1.12.10982.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

This is definitely a nitpick but shouldn't the Discard changes and Save buttons in the settings view be the other way round to match the rest of the Windows design?

image

compared to

image

image

image

image

image

Even the Close all tabs dialog in Terminal has the commit button left-to-right 😜

image

More examples: https://docs.microsoft.com/en-us/windows/win32/uxguide/ctrl-command-buttons

Expected Behavior

image

Actual Behavior

image
@danielchalmers danielchalmers added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 25, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 25, 2022
@zadjii-msft
Copy link
Member

@cinnamon-msft for UI design feedback

Obviously this is a ship-blocking issue, I don't know how this ever passed review 😝

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Needs-Discussion Something that requires a team discussion before we can proceed labels May 25, 2022
@zadjii-msft
Copy link
Member

consensus: we couldn't come up with the reason we went with this one. We could not find a counter example that validated the design we currently have.

We may also just get rid of these for #10627

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. good first issue This is a fix that might be easier for someone to do as a first contribution and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Jun 6, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jun 6, 2022
@PankajBhojwani PankajBhojwani mentioned this issue Jun 6, 2022
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Jun 6, 2022
@ghost ghost closed this as completed in #13237 Jun 7, 2022
ghost pushed a commit that referenced this issue Jun 7, 2022
@PankajBhojwani
Reorder "save" and "discard changes" buttons in the SUI (#13237)
f4c4efc 
"Save" is now the first button, "Discard changes" is now the second button

## PR Checklist
* [x] Closes #13174
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jun 7, 2022
@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13237, which has now been successfully released as Windows Terminal Preview v1.15.186.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Reorder "save" and "discard changes" buttons in the SUI microsoft/terminal
2 participants
@danielchalmers @zadjii-msft