Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab reordering drag and drop approach is confusing #3734

Closed
andriysavin opened this issue Nov 27, 2019 · 7 comments
Closed

Tab reordering drag and drop approach is confusing #3734

andriysavin opened this issue Nov 27, 2019 · 7 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone

Comments

@andriysavin
Copy link

andriysavin commented Nov 27, 2019

I find it confusing from the point of user experience that tab reordering is visually implemented as regular drag and drop. It makes me feel that in addition to reordering I can:

a) detach a tab into its own window, like I'm used to do with web browser tabs;
b) drag a tab from one terminal window to other and thus move the tab between windows (again, like in web browsers);
c) and some users may even expect that they can drop a tab into some other app (e.g. embed it into a word document).

My opinion on this is unless implementing features mentioned above is on the roadmap, tab reordering should not allow dragging a tab outside of the tab panel. Instead, the tab being moved should slide within the tab row. A good example is how the tabs are visually sliding during reordering in MS Edge (Chromium version).

And even if tab detaching is planned, it can be done exactly the same as in Edge (Chromium), i.e. the tab header is not floating with the mouse, but is detached with tab content after significant mouse movement.

@andriysavin andriysavin added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 27, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 27, 2019
@zadjii-msft
Copy link
Member

Thanks for the feedback! I definitely agree with the points you're making. Fortunately, tab tear-out is on the roadmap, but likely not until after 1.0. Before that, we should definitely just keep the tab in the row, with the sliding behavior. This is great feedback for the XAML team (and @teaP in particular ☺️).

I've filed microsoft/microsoft-ui-xaml#1685 upstream to make sure this gets added to WinUI, and so we can ingest it ourselves.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem. labels Nov 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 27, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Nov 27, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 30, 2019
@zadjii-msft zadjii-msft removed the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 9, 2020
@tstager
Copy link

tstager commented Apr 24, 2020

Do you guys realize that tab reordering crashes terminal if it was run as an administrator?

@DHowett-MSFT
Copy link
Contributor

Uh we definitely fixed a bug like that two whole versions ago. Can you confirm the version you’re on?

@tstager
Copy link

tstager commented Apr 24, 2020

0.11.1121.0

1 similar comment
@tstager
Copy link

tstager commented Apr 24, 2020 via email

@DHowett-MSFT
Copy link
Contributor

#5542

It looks like we regressed this when we were cleaning some stuff up.

@zadjii-msft
Copy link
Member

Huh so I'm looking through the backlog here, and I honestly think we're gonna get to #1256 before the WinUI team is going to be able to get to microsoft/microsoft-ui-xaml#1685. They're pretty swamped with Win11 work at the moment, and we've been making a lot of progress towards tear-out (see #5000).

I'm just going to close this for now. It's still a good idea for the WinUI TabView, but one we probably won't end up needing ourselves 😅

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Development

No branches or pull requests

5 participants