Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal background color has the wrong color applied when terminal is snapped #5178

Closed
soul4soul opened this issue Mar 30, 2020 · 7 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@soul4soul
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.720]
Windows Terminal version (if applicable): 0.10.781.0

Any other software? A preview version of PS7 which displays a "new release is available banner"

Steps to reproduce

  1. Configure PS 7 preview shell as the default profile
  2. Launch WT
  3. Snap terminal left immediately after launch as soon as WT is visible. I suspect it needs to get snapped while the banner is being drawn before the shell is ready for input.
  4. See background color from the PS 7 new release banner is used for the entire terminals background color
  5. As new text is drawn to the window the background color starts to go away and correct itself.

I saw this behavior by off change. After it happened once I was able to repo after a dozen or so launches.

Expected behavior

  1. The background color used by the new release banner should not be drawn over the entire terminal window.

Actual behavior

  1. Banner background is used as the terminal background color

First time it happened:
image

Second time it happened:
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 30, 2020
@zadjii-msft
Copy link
Member

Thanks for the report! This is actually one of the oldest bugs in the console, and already being tracked by another issue on our repo - please refer to #32 for more discussion.

/dup #32

@ghost
Copy link

ghost commented Mar 30, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 30, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 30, 2020
@soul4soul
Copy link
Author

@zadjii-msft
This issue seems slightly different from #32. In all screenshots provided in #32 only the line with the colored region is draw to the end of that line.

I'm seeing other lines be drawn with the colored region. Lines which were emitted before the color region are using the colored region color. Another symptom I see is the BG color continues to use the the color from the banner even after I enter new commands and the window scrolls.

I can still accept it's a dupe. I just want to be clear about the problem I see.

image
image

@zadjii-msft
Copy link
Member

Ah yea, okay, I see it now. That's what I get for triaging in the morning.

Looks like the problem is that when the buffer is getting resized, we're using the current attributes to initialize all the lines, not the default attributes. If you do the resize while the banner is being drawn, that means the attributes have been set to black-on-white, which is why the white seems to have filled the rest of the buffer.

It's a similar bug to #32, but it's definitely unique. I'll re-triage

@zadjii-msft zadjii-msft reopened this Mar 31, 2020
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. and removed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. labels Mar 31, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Mar 31, 2020
@j4james
Copy link
Collaborator

j4james commented Mar 31, 2020

This sounds like the same problem as #3848 (comment).

@zadjii-msft
Copy link
Member

Oh dang, you're totally right @j4james. Thanks for finding that!

/dup #3848

@ghost
Copy link

ghost commented Apr 1, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@zadjii-msft zadjii-msft removed this from the Terminal v1.0 milestone Apr 1, 2020
@ghost ghost closed this as completed Apr 1, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Apr 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants