Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs in title bar are cut off when scrolling the tabs + tabs not scrolling automatically #857

Closed
futilityteam opened this issue May 16, 2019 · 5 comments · Fixed by #3027
Closed

Tabs in title bar are cut off when scrolling the tabs + tabs not scrolling automatically #857

futilityteam opened this issue May 16, 2019 · 5 comments · Fixed by #3027
Assignees
@DHowett-MSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@futilityteam
Copy link

This bug-tracker is monitored by Windows Console development team and other technical types. We like detail!

Please use this form and describe your issue, concisely but precisely, with as much detail as possible

  • Your Windows build number: (Type ver at a Windows Command Prompt)
    Microsoft Windows [Version 10.0.18898.1000]

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
    Video demonstration of both issues below

    • A newly created tab doesn't scroll the tab bar to the end - could possibly be a config variable
    • When using tabs in the title bar and creating a new partially hidden tab, the tab gets cut off.

  • What's wrong / what should be happening instead:

    • The tab should not be cut off.
@DHowett-MSFT DHowett-MSFT self-assigned this May 16, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels May 16, 2019
@zadjii-msft
Copy link
Member

@teaP might be interested in this

@futilityteam
Copy link
Author

I just pulled this repo and recompiled, and it works fine. But please test it for yourself before closing this issue, because it may break again in the next commmit. 😀

@krzysdz
Copy link
Contributor

krzysdz commented Jun 10, 2019

I've just experienced the same issue, but in my case it also caused some tabs not to be displayed at all.
The invisible and cut off tabs appear again after resizing the window.

Details:

  • Commit: b9d83ba
  • Windows build: 18362.145

@zadjii-msft zadjii-msft mentioned this issue Jun 14, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Jun 14, 2019
Closed
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 19, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Jun 22, 2019
Closed
@allen-chin allen-chin mentioned this issue Jun 22, 2019
Closed
29 tasks
@ArtexJay
Copy link

My tab is not even scrolling on my computer. If i have too many tabs open I just can access it until i close a few tabs.
Also it would be great if the tabs would only display the name and not the directory, so for Command Prompt tab it could say CMD, or Command, for Ubuntu terminal it could say Ubuntu, same for any other Linux terminal, for Powershell it could just say Powershell.
Having the entire directory in the tab feels and looks strange.

This was referenced Jun 22, 2019
Closed
Closed
Closed
Closed
@miniksa miniksa mentioned this issue Jun 27, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 1, 2019
Closed
This was referenced Jul 8, 2019
Closed
Closed
Closed
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 29, 2019
Closed
@krzysdz krzysdz mentioned this issue Aug 12, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 28, 2019
Closed
@encladeus encladeus mentioned this issue Sep 1, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Sep 3, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 3, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 19, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 2, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 2, 2019
@j4james j4james mentioned this issue Oct 5, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 8, 2019
Closed
@j4james j4james mentioned this issue Oct 10, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 11, 2019
Closed
DHowett-MSFT pushed a commit that referenced this issue Oct 15, 2019
@DHowett
Upgrade to Microsoft.UI.Xaml 2.2 (#3027)
df26c67 
* We had to move to the final API:
   * Items -> TabItems
   * Items.VectorChanged -> TabItemsChanged
   * TabClose -> TabCloseRequested
   * TabViewItem.Icon -> TabViewItem.IconSource
* TabRowControl has been converted to a ContentPresenter, which
  simplifies its logic a little bit.
* TerminalPage now differentiates MUX and WUX a little better
* Because of the change from Icon to IconSource in TabViewItem,
  Utils::GetColoredIcon needed to be augmented to support MUX IconSources.
  It was still necessary to use for WUX, so it's been templatized.
* I moved us from WUX SplitButton to MUX SplitButton and brought the
  style in line with the one typically provided by TabView.
* Some of our local controls have had their backgrounds removed so
  they're more amenable to being placed on other surfaces.
* I'm suppressing the TabView's padding.
* I removed a number of apparently dead methods from App.
* I've simplified the dragbar's sizing logic and eventing.
* The winmd harvester needed to be taught to not try to copy winmds for
  framework packages.
* We now only initialize the terminal once we know the size

Closes #1896.
Closes #444.
Closes #857.
Closes #771.
Closes #760.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 15, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3027, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Upgrade to Microsoft.UI.Xaml 2.2 microsoft/terminal
5 participants
@krzysdz @DHowett-MSFT @miniksa @zadjii-msft @ArtexJay