Allow editing font features in the Settings UI #16678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/pabhoj/sui_font_parity
…/pabhoj/sui_font_parity
PankajBhojwani
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
microsoft-github-policy-service
bot
dismissed stale reviews from zadjii-msft and lhecker
The base branch was changed.
PankajBhojwani
added
the
AutoMerge
|
@lhecker @zadjii-msft could you approve again? it dismissed your reviews because the base changed |
zadjii-msft
approved these changes
Feb 29, 2024
lhecker
approved these changes
Feb 29, 2024
microsoft-github-policy-service
bot
merged commit 6e451a2
into
main
18 of 20 checks passed
microsoft-github-policy-service
bot
deleted the
dev/pabhoj/sui_font_features
branch
zadjii-msft
pushed a commit
that referenced
this pull request
Mar 1, 2024
Make sure the delete button's `Tag` updates when the selected axis/feature changes, so that the correct key value gets propagated when the delete button is clicked. Refs #16678 #16104 ## Validation Steps Performed 1. Add a new feature/axis 2. Change the key 3. Click the delete button 4. Delete button works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Targets #16104
Same as #16104, but for font features
References and Relevant Issues
#10000
Validation Steps Performed
Font features are detected correctly and can be set in the settings UI
PR Checklist