Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bad default light theme selection background color #16789

Merged

Conversation

uoRetr0
Copy link
Contributor

@uoRetr0 uoRetr0 commented Feb 29, 2024

Summary of the Pull Request

Fixed default selection background colors with light schemes. Default color now matches the scheme and contrasts well

References and Relevant Issues

none

Detailed Description of the Pull Request / Additional comments

This is my first contribution ever :) Even though its simple, im happy to help

Validation Steps Performed

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 29, 2024
@DHowett DHowett changed the title Bad default selection background color Fix the bad default light theme selection background color Feb 29, 2024
@DHowett
Copy link
Member

DHowett commented Feb 29, 2024

You submitted this pull request at just the right time! We finally fixed a long-standing issue where changes to the default color schemes would be ignored for existing users. Thanks!

We'll get this reviewed ASAP

@zadjii-msft
Copy link
Member

OneHalf light:
image

Solarized:
image

Tango:
image

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I think we technically already did this over in #16243. When that PR was authored, it didn't get linked up to #8716 quite right, so it didn't get closed.

I'm fine merging this, as the new colors are still good too

@zadjii-msft zadjii-msft added this pull request to the merge queue Apr 29, 2024
Merged via the queue into microsoft:main with commit 6bc7b9e Apr 29, 2024
15 checks passed
@uoRetr0 uoRetr0 deleted the Bad-default-selection-background-color branch April 29, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad default selection background color with light schemes
4 participants