Make ColorFromXOrgAppColorName both smaller and more correct #16824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to use `stringstream` to generate a ten-character string, and we for _sure_ don't need to use the locale-aware ctype functions after we just wrote a comment saying "XOrg colors are always Latin-1" | Size Diff | Object | Library | | --------- | -------------- | -------- | | -11.8 KB | colorTable.obj | ConTypes |
DHowett
changed the title
lhecker
approved these changes
Mar 5, 2024
lhecker
added
the
Area-CodeHealth
zadjii-msft
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to use
stringstreamto generate a ten-character string, and we for sure don't need to use the locale-aware ctype functions after we just wrote a comment saying "XOrg colors are always Latin-1"