-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for turning off full-color Emoji #16871
Add support for turning off full-color Emoji #16871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First!
src/renderer/atlas/BackendD3D.cpp
Outdated
@@ -1316,7 +1316,12 @@ BackendD3D::AtlasGlyphEntry* BackendD3D::_drawGlyph(const RenderingPayload& p, c | |||
}); | |||
|
|||
{ | |||
const auto enumerator = TranslateColorGlyphRun(p.dwriteFactory4.get(), {}, &glyphRun); | |||
wil::com_ptr<IDWriteColorGlyphRunEnumerator1> enumerator{ nullptr }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: No need to write out { nullptr }
explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh true
This pull request introduces support for disabling full-color emoji (and technically other COLR-related font features!)
Full-color emoji don't respond to SGR colors, intensity, faint or blink. Some users also just prefer the line art ones.
Related to #15979
Refs #1790
Closes #956