Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop updating AutoSuggestBox on selection redux #18010

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Stop updating AutoSuggestBox on selection redux #18010

merged 2 commits into from
Oct 23, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Oct 8, 2024 •
edited by zadjii-msft
Loading

I wrote a big comment next to the changes I made.
This is a redo of #17961 which had various issues.

Closes #17916
Closes #18070

Validation Steps Performed

  • Pressing Enter within the input line doesn't crash ✅
  • Type "Cour" and pick Courier New, press Save = Saved ✅
  • Pick any other font from the dropdown, press Save = Saved ✅
  • Picking an option dismisses focus but not to the tab row ✅
  • The first time after launching the SUI, when the setting is still
    unmodified, when you focus the box and pick an option,
    it'll unfocus the box ✅
  • When the setting is unmodified, and you pick the default
    (Cascadia Mono), it'll still unfocus the box ✅

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Oct 8, 2024
@lhecker lhecker mentioned this pull request Oct 9, 2024
Closed
carlos-zamora
carlos-zamora approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@lhecker lhecker mentioned this pull request Oct 17, 2024
Closed
@zadjii-msft
Copy link
Member

Service to 1.22?

@DHowett
Copy link
Member

DHowett commented Oct 23, 2024

1.22

Nah. It didn't fix anything to begin with AFAIK

DHowett
DHowett approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My god.

src/cascadia/TerminalSettingsEditor/Appearances.cpp
@@ -1049,6 +1045,22 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
}

sender.Text(fontSpec);

// Normally we'd just update the model property in LostFocus above, but because WinUI is the Ralph Wiggum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BODGY

@DHowett DHowett merged commit 8d3f12b into main Oct 23, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/17916-again branch October 23, 2024 22:20
@microsoft-github-policy-service microsoft-github-policy-service bot added the Area-Settings UI Anything specific to the SUI label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
4 participants
@lhecker @zadjii-msft @DHowett @carlos-zamora