-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style the button and tab view background to match the titlebar #1934
Conversation
nit: rename pull request to be in imperative form. Imagine that you're completing the sentence, "[if merged,] this pull request will..." "style the title bar" |
Background="{ThemeResource ApplicationPageBackgroundThemeBrush}" | ||
HorizontalAlignment="Left" | ||
Background="{ThemeResource SystemChromeLowColor}" | ||
HorizontalAlignment="Left" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing issues
@@ -130,7 +130,10 @@ | |||
</StackPanel.Resources> | |||
|
|||
<Grid x:Name="Content"></Grid> | |||
<Border Height="36.0" MinWidth="160.0" x:Name="DragBar" Background="{ThemeResource ApplicationPageBackgroundThemeBrush}" DoubleTapped="DragBar_DoubleTapped"/> | |||
<Border Height="36.0" | |||
MinWidth="160.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a loottt of spaces here. could you align the properties vertically after the space after the tag name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I think this is a tab/spaces thing)
@@ -31,7 +31,7 @@ | |||
</ResourceDictionary> | |||
<ResourceDictionary x:Key="Dark"> | |||
<x:Double x:Key="CaptionButtonStrokeWidth">1.0</x:Double> | |||
<StaticResource x:Key="CaptionButtonBackground" ResourceKey="SystemControlBackgroundAltHighBrush"/> | |||
<StaticResource x:Key="CaptionButtonBackground" ResourceKey="SystemChromeLowColor"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to make these Transparent so the Row peeks through
@@ -18,7 +18,7 @@ | |||
<ResourceDictionary.ThemeDictionaries> | |||
<ResourceDictionary x:Key="Light"> | |||
<x:Double x:Key="CaptionButtonStrokeWidth">1.0</x:Double> | |||
<StaticResource x:Key="CaptionButtonBackground" ResourceKey="SystemControlBackgroundAltHighBrush"/> | |||
<StaticResource x:Key="CaptionButtonBackground" ResourceKey="SystemChromeLowColor"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(as below)
@@ -23,21 +23,28 @@ the MIT License. See LICENSE in the project root for license information. --> | |||
<ColumnDefinition Width="Auto"/> | |||
</Grid.ColumnDefinitions> | |||
|
|||
<mux:TabView x:Name="TabView" Grid.Column="0" /> | |||
<mux:TabView x:Name="TabView" Grid.Column="0" | |||
SelectionChanged="TabView_SelectionChanged" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this and the other selectionchanged thingos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pretty much have the same comments that Dustin has
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -130,7 +130,11 @@ | |||
</StackPanel.Resources> | |||
|
|||
<Grid x:Name="Content"></Grid> | |||
<Border Height="36.0" MinWidth="160.0" x:Name="DragBar" Background="{ThemeResource ApplicationPageBackgroundThemeBrush}" DoubleTapped="DragBar_DoubleTapped"/> | |||
<Border Height="36.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does GH think this line wrapped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that in
@cinnamon-msft cool, cool cool cool cool cool. |
…soft#1934) * styled title bar to be one color, shrunk + button
🎉 Handy links: |
You need to switch your Windows theme from light to dark in the settings app. |
Oh, I understand now. I prefer a light theme for the rest of the system. I guess I'll stick with the white borders for now. It'd be nice to be able to change this from the |
You can set the app to use dark themes in the settings |
Yeah, it’s called “requestedTheme”. |
Thank you! I was indeed going to ask what the option is :) |
Summary of the Pull Request
Added additional styling to the title bar so it looks cohesive and tweaked the + button so it's not so large.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed