Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll up WindowsTerminal's subprojects into packaging outputs #2007

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

DHowett-MSFT
Copy link
Contributor

This may be a targeted fix that obviates the need for #2002 without going all the way to #1995.

@DHowett-MSFT DHowett-MSFT requested a review from zadjii-msft July 17, 2019 17:38
@DHowett-MSFT
Copy link
Contributor Author

Oh my god it works.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh OK fine. :shipit:

@zadjii-msft
Copy link
Member

So with this in, can we close #2002? Because I'd love to not have to do that.

@DHowett-MSFT DHowett-MSFT merged commit de1de44 into master Jul 17, 2019
@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/why_do_you_roll_me_up,_buttercup branch July 17, 2019 21:02
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
…ft#2007)

This commit introduces a GetPackagingOutputs override to WindowsTerminal that
rolls up its child projects' outputs.

It also introduces an atrocity that fixes a new regression in VS 16.2/16.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants