From 4026178b266c6f5adaf47a79636593da1dc5b7ae Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Tue, 5 May 2020 08:17:53 -0500 Subject: [PATCH] We can just skip this call for now --- src/cascadia/TerminalApp/TerminalPage.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index f5c1ec2184d..08290e826b3 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -911,8 +911,12 @@ namespace winrt::TerminalApp::implementation } }); + // TODO GH#3327: Once we support colorizing the NewTab button based on + // the color of the tab, we'll want to make sure to call + // _ClearNewTabButtonColor here, to reset it to the default (for the + // newly created tab). // remove any colors left by other colored tabs - _ClearNewTabButtonColor(); + // _ClearNewTabButtonColor(); } // Method Description: @@ -1929,6 +1933,11 @@ namespace winrt::TerminalApp::implementation winrt::Windows::UI::Xaml::Media::SolidColorBrush backgroundBrush; winrt::Windows::UI::Xaml::Media::SolidColorBrush foregroundBrush; + // TODO: Related to GH#3917 - I think if the system is set to "Dark" + // theme, but the app is set to light theme, then this lookup still + // returns to us the dark theme brushes. There's gotta be a way to get + // the right brushes... + // See also GH#5741 if (res.HasKey(defaultBackgroundKey)) { winrt::Windows::Foundation::IInspectable obj = res.Lookup(defaultBackgroundKey);