Test methods with generic parameters don't show source locations in Microsoft.Testing.Platform mode in Test Explorer

[bradwilson]

When xUnit.net v3 test projects are in Microsoft Testing Platform mode, source information is missing when the test method parameter is generic.

Recording.2024-09-24.210427.mp4

Reproduced with:

• VS 2022 17.12 Preview 2
• NuGet package xunit.v3 version 0.4.0-pre.20

[bradwilson]

On a hunch, I brought back my implementation of https://github.com/microsoft/vstest/blob/main/docs/RFCs/0017-Managed-TestCase-Properties.md and now everything is working as expected.

I don't remember what issue it was in, but someone from the VSTest team told me this was outdated and no longer needed. That information appeared to be incorrect.

So...what's the story here? Is this working right now because Test Explorer hasn't been updated yet? Or is this working right now because the advice to just use .FullName was incorrect?

/cc @MarcoRossignoli

Here's 2022 17.11 in VSTest mode:

Here's 2022 17.12 Preview 2 in MTP mode:

[bradwilson]

I set up a branch for the changes: https://github.com/xunit/xunit/tree/testfx-3863

[bradwilson]

I don't remember what issue it was in, but someone from the VSTest team told me this was outdated and no longer needed.

Found it: #3478 (comment)

[bradwilson]

Also, if this is the answer:

Is this working right now because Test Explorer hasn't been updated yet?

Then what is the migration path forward? Will Test Explorer support both styles into the future so as to preserve backward compatibility with test frameworks that are emitting the "VSTest" style vs. the "FullName" style? If so, for how long? We obviously don't want to unnecessarily degrade users who are stuck on older builds of Visual Studio that might still be supported.