Match commands against each line #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Sep 7, 2023
| const botCall = "@typescript-bot"; | ||
| for (const [key, value] of [...commands.entries()]) { | ||
| commands.delete(key); | ||
| commands.set(new RegExp(`${botCall} ${key.source}`, "i"), value); |
There was a problem hiding this comment.
I feel like this should be ^${botCall} but it's not a change in logic to keep it this way, I guess.
jakebailey
commented
Sep 7, 2023
| @@ -522,6 +522,13 @@ const commands = (/** @type {Map<RegExp, CommentAction>} */(new Map())) | |||
| await triggerGHActionWithComment(request, "run-twoslash-repros", { number: issueNumber || prNumber || undefined }, `run the code sample repros`); | |||
| }, undefined, false)); | |||
|
|
|||
|
|
|||
| const botCall = "@typescript-bot"; | |||
| for (const [key, value] of [...commands.entries()]) { | |||
There was a problem hiding this comment.
This is done early so we don't recalculate each regex multiple times; I could have done this up front in the regexes above or made an add method, but I didn't want to make the diff that bad.
andrewbranch
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we match each command regex against the entire body; this means that each command can only execute once. That means that we can't ask the bot to do two of the same task, e.g. run two different perf runs with different arguments. Example: microsoft/TypeScript#55267 (comment)
Instead, split the body by lines, dedupe, then check each command against each of them, allowing each command to run more than once on the same body.