Port tsc --init #2033
Port tsc --init #2033
Conversation
| fieldName, _, _ = strings.Cut(jsonTag, ",") | ||
| } | ||
|
|
||
| if fieldName != "" && fieldName != "init" && fieldName != "help" && fieldName != "watch" { |
There was a problem hiding this comment.
I think there are other options like --all that also have to be dropped. Do we have some preexisting way to identify these rather than hardcoding them?
There was a problem hiding this comment.
Ah, no, this is actually straight ported. Fun. That's probably a bug!
| // commentedAlways': Always comment this out, even if it's on commandline | ||
| // commentedOptional': Comment out unless it's on commandline | ||
| const ( | ||
| commentedNever = 0 |
There was a problem hiding this comment.
You can probably declare a local type and use iota here.
| "moduleDetection": "force", | ||
| "skipLibCheck": true, | ||
|
|
||
| "declarationDir": "/home/src/workspaces/project/lib", |
There was a problem hiding this comment.
This path is printed incorrectly; it shouldn't include an absolute path.
There was a problem hiding this comment.
I think this might come down to the fact that our compiler options are fully resolved now, whereas the old code was not? In which case, you may need to resolve any path-like options relative to the working directory. But since you're just reflecting over options instead of going via options declarations, I am not sure how simple that is.
Perhaps this means we should change the method to not be like Strada and instead use the options declarations to find values... Which would probably also let us not special case the things I mentioned above.
2 participants
This PR ports
tsc --initfromStrada.Fixes #1602