Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gflags] build failure with release-only build #35368

Closed
adamreeve opened this issue Nov 28, 2023 · 1 comment · Fixed by #35373
Closed

[gflags] build failure with release-only build #35368

adamreeve opened this issue Nov 28, 2023 · 1 comment · Fixed by #35373
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@adamreeve
Copy link
Contributor

adamreeve commented Nov 28, 2023

Operating system

Linux (Fedora 39)

Compiler

GCC 13.2.1

Steps to reproduce the behavior

cp $VCPKG_ROOT/triplets/x64-linux.cmake ./x64-linux-release.cmake
echo "set(VCPKG_BUILD_TYPE release)" >> ./x64-linux-release.cmake
vcpkg install --triplet=x64-linux-release --overlay-triplets=$PWD gflags

Failure logs

Computing installation plan...
The following packages will be built and installed:
	gflags:x64-linux-release -> 2.2.2#8
Detecting compiler hash for triplet x64-linux-release...
Restored 0 package(s) from /home/adam/.cache/vcpkg/archives in 6.62 us. Use --debug to see more details.
Installing 1/1 gflags:x64-linux-release...
Building gflags:x64-linux-release...
-- [OVERLAY] Loading triplet configuration from: /home/adam/dev/gflags_repro/x64-linux-release.cmake
-- Using cached gflags-gflags-v2.2.2.tar.gz.
-- Cleaning sources at /home/adam/dev/vcpkg/buildtrees/gflags/src/v2.2.2-d9283b9285.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/adam/dev/vcpkg/downloads/gflags-gflags-v2.2.2.tar.gz
-- Applying patch 0001-patch-dir.patch
-- Applying patch fix_cmake_config.patch
-- Using source at /home/adam/dev/vcpkg/buildtrees/gflags/src/v2.2.2-d9283b9285.clean
-- Found external ninja('1.11.1').
-- Configuring x64-linux-release
-- Building x64-linux-release-rel
-- Fixing pkgconfig file: /home/adam/dev/vcpkg/packages/gflags_x64-linux-release/lib/pkgconfig/gflags.pc
CMake Error at scripts/cmake/vcpkg_replace_string.cmake:2 (file):
  file failed to open for reading (No such file or directory):

	/home/adam/dev/vcpkg/packages/gflags_x64-linux-release/debug/lib/pkgconfig/gflags.pc
Call Stack (most recent call first):
  ports/gflags/portfile.cmake:29 (vcpkg_replace_string)
  scripts/ports.cmake:170 (include)

Additional context

This looks related to the changes from #35188 (cc @dg0yt). I tested with the commit prior to this change (ce8fd9e7246969886ee31cbd76955b6d444289cb) and the build succeeds, but it fails at a44d019a38fe7217222a4780a9ed0d62691123ae.

@adamreeve adamreeve added the category:port-bug The issue is with a library, which is something the port should already support label Nov 28, 2023
adamreeve added a commit to adamreeve/ParquetSharp that referenced this issue Nov 28, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Nov 28, 2023

Thanks for reporting. I guess I was too angry about pc files being completely removed ;-)

x64-linux-release exists as a community triplet. So the issue can be reproduced immediately without overlay triplets:

vcpkg install gflags:x64-linux-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants