[lapack-reference|fortran] Add new port #12805

Neumann-A · 2020-08-07T12:32:46Z

Again. New approach without touching any main files. Other PR seemed broken not running in CI.

How it works:
If Fortran compiler is on path: Use that.
If VCPKG_CHAINLOAD_TOOLCHAIN is set: Assume Fortran compiler is setup by the toolchain.

If no Fortran compiler:
Windows: Use gfortran from MinGW and create a freestanding dll. using cmakes GNUtoMS
Others: Error with a message to install a Fortran compiler.

ports/clapack/portfile.cmake

ports/lapack-reference/CONTROL

Neumann-A · 2020-08-07T14:41:15Z

@cenit: Feel free to review and test this one.

Neumann-A · 2020-08-07T18:38:19Z

@cenit any opinion on using openblas on OSX? The current osx failure is due to blas.pc missing and i would need to create one for the accelerate framework.

…gfortran

centi · 2020-08-07T19:22:29Z

@Neumann-A To be honest, I have no idea what this is about. Could you please clarify how am I connected to this? Did I report some issue (I've searched the issues but did not find any reported by me)?

I'm not sure if I ever used this tool, but maybe I did (or some other tool which uses this as a dependency) a long time ago and forgotten about it since. Anyway, I no longer use OSX, so I cannot help with the last question either.

Neumann-A · 2020-08-07T19:23:52Z

@centi typo i meant cenit ;)

cenit · 2020-08-07T19:34:45Z

@centi typo i meant cenit ;)

Go for OpenBLAS also on osx. The current situation is very comparable with the accelerate framework, or even better. This is not true for clapack, but that's the whole scope of this PR

Neumann-A · 2020-08-08T06:21:59Z

@cbezault @vicroms: opinions?

ports/clapack/portfile.cmake

ports/lapack/portfile.cmake

ports/openblas/portfile.cmake

ports/vcpkg-gfortran/portfile.cmake

ports/mlpack/cmakelists.patch

scripts/ci.baseline.txt

strega-nil · 2020-08-12T17:28:38Z

This is amazing! Thanks @Neumann-A :)

janholt · 2020-08-21T14:27:33Z

ports/lapack/portfile.cmake has check for find_package(LAPACK):

if(VCPKG_TARGET_IS_UWP OR VCPKG_TARGET_IS_WINDOWS AND VCPKG_TARGET_ARCHITECTURE MATCHES "arm")
    # Install clapack wrappers. 
    file(INSTALL ${CMAKE_CURRENT_LIST_DIR}/clapack/vcpkg-cmake-wrapper.cmake DESTINATION ${CURRENT_PACKAGES_DIR}/share//${PORT})
    file(INSTALL ${CMAKE_CURRENT_LIST_DIR}/clapack/FindLAPACK.cmake DESTINATION ${CURRENT_PACKAGES_DIR}/share//${PORT})
endif()
vcpkg_configure_cmake(SOURCE_PATH ${CURRENT_PORT_DIR}
                      OPTIONS -DCMAKE_PREFIX_PATH="${CURRENT_PACKAGES_DIR}")

seems it does not work in case of custom clapack/FindLAPACK.cmake installed (under the if clause): -DCMAKE_PREFIX_PATH="${CURRENT_PACKAGES_DIR}" does not participate in finding vcpkg-cmake-wrapper.cmake or FindLAPACK.cmake.

Possible solution is to use -DCMAKE_MODULE_PATH="${CURRENT_PACKAGES_DIR}/share/${PORT}"

* [vcpkg/script] add vcpkg_find_fortran * [openblas] add pkg-config fixes * [lapack] add lapack-reference and reduce dependency on clapack * fix build issues * dont touch any main files * move toolchain var into parent scope * fix a few more issues * create link in the noblas case * removed unnecessary check handled by vcpkg_find_fortran. * move dumpbin check * fix last issue * depend on openblas * set cmake_binary_dir so that compiler id run gets put into buildtree. * more paths * add missing PARENT_SCOPE * ws change * [mlpack] remove dep on clapack * comment out patches * remove openblas again * Install lapack wrapper since it is missing linkage against -lm and -lgfortran * PREPEND mingw path to make sure cmake picks it up correctly * depend on openblas also on osx * add clapack on windows to skip due to conflicting library installs * add clapack to skip on linux * add -fPIC as a fortran compiler flag * do not add the flag on windows * add gcc explicitly to the cmake args. * ws change * applyrequested changes from CR * fix the failing patch

JackBoosY · 2021-08-17T02:44:49Z

scripts/cmake/vcpkg_find_fortran.cmake

+            if(VCPKG_CRT_LINKAGE STREQUAL "static")
+                set(VCPKG_CRT_LINKAGE dynamic PARENT_SCOPE)
+                message(STATUS "VCPKG_CRT_LINKAGE linkage for ${PORT} using vcpkg's internal gfortran cannot be static due to linking against MinGW libraries. Forcing dynamic CRT linkage")
+            endif()
+            if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
+                set(VCPKG_LIBRARY_LINKAGE dynamic PARENT_SCOPE)
+                message(STATUS "VCPKG_LIBRARY_LINKAGE linkage for ${PORT} using vcpkg's internal gfortran cannot be static due to linking against MinGW libraries. Forcing dynamic library linkage")
+            endif()


This may breaks the unity of CRT linkage. Should we use vcpkg_check_linkage instead?

dynamic only linkage in a static triplet cause an error. This would trigger a lot of cascade ports to fail without any notice. it’s very different from a static linkage in a dynamic triplet

while the original line is very problematic, as you say, also the fix would trigger many problems

#19413 solves all the problems with gfortran by switching to the ifort instead. CRT linkage is also not that important if memory is not passed between the different CRTs.

dg0yt · 2023-01-02T07:31:17Z

ports/lapack-reference/portfile.cmake

+set(CBLAS OFF)
+if("cblas" IN_LIST FEATURES)
+    set(CBLAS ON)
+endif()
+
+set(USE_OPTIMIZED_BLAS OFF) 
+if("noblas" IN_LIST FEATURES)
+    set(USE_OPTIMIZED_BLAS ON)
+    set(pcfile "${CURRENT_INSTALLED_DIR}/lib/pkgconfig/openblas.pc")
+    if(EXISTS "${pcfile}")
+        file(CREATE_LINK "${pcfile}" "${CURRENT_PACKAGES_DIR}/lib/pkgconfig/blas.pc" COPY_ON_ERROR)
+    endif()
+    set(pcfile "${CURRENT_INSTALLED_DIR}/debug/lib/pkgconfig/openblas.pc")
+    if(EXISTS "${pcfile}")
+        file(CREATE_LINK "${pcfile}" "${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/blas.pc" COPY_ON_ERROR)
+    endif()
+endif()
+
+set(VCPKG_CRT_LINKAGE_BACKUP ${VCPKG_CRT_LINKAGE})
+vcpkg_find_fortran(FORTRAN_CMAKE)
+if(VCPKG_USE_INTERNAL_Fortran)
+    if(VCPKG_CRT_LINKAGE_BACKUP STREQUAL static) 
+    # If openblas has been built with static crt linkage we cannot use it with gfortran!
+        set(USE_OPTIMIZED_BLAS OFF) 
+        #Cannot use openblas from vcpkg if we are building with gfortran here. 
+        if("noblas" IN_LIST FEATURES)
+            message(FATAL_ERROR "Feature 'noblas' cannot be used without supplying an external fortran compiler")
+        endif()
+    endif()
+else()
+    set(USE_OPTIMIZED_BLAS ON)
+endif()


@Neumann-A Is this the desired outcome of feature configuration, in particular with regard to enabling OPTIMZED_BLAS?

Requested features Static CRT & internal Fortran Otherwise Dependencies

core - OPTIMIZED_BLAS none

cblas CBLAS CBLAS, OPTIMIZED_BLAS none

noblas - OPTIMIZED_BLAS blas (->openblas)

cblas,noblas error error blas (->openblas)

I'm concerned about OPTIMIZED_BLAS being enabled for the "Otherwise" "core"/"cblas" cases. The build result will depend on the result of find_package(BLAS). I would assume OPTIMIZED_BLAS should be restricted to the noblas case so that the actual dependency can be switched in a controlled way by overriding port blas.

see #24327. But what vcpkg really needs is a) options RFC and b) a proper Windows Fortran compiler. (#24622)

That PR doesn't clearly adress the particular aspect I'm looking at: set(USE_OPTIMIZED_BLAS ON) at Line 54 regardless of features. In turn this will enable find_package(BLAS) in the project regardless of controlled dependencies. I'm proposing to turn this off. The effective result would be:

Requested features Static CRT & internal Fortran Otherwise Dependencies

core - - none

cblas CBLAS CBLAS none

noblas - OPTIMIZED_BLAS blas (->openblas)

cblas,noblas error error blas (->openblas)

ah i see simply removing line 53-54 should be enough.

Neumann-A added 10 commits August 7, 2020 13:35

[vcpkg/script] add vcpkg_find_fortran

d7a475c

[openblas] add pkg-config fixes

7dbb51c

[lapack] add lapack-reference and reduce dependency on clapack

9470516

fix build issues

7602456

dont touch any main files

7c641d0

move toolchain var into parent scope

21fb89f

fix a few more issues

8247cd3

create link in the noblas case

81cfb5b

removed unnecessary check handled by vcpkg_find_fortran.

0685ce0

move dumpbin check

2035353

Neumann-A commented Aug 7, 2020

View reviewed changes

ports/clapack/portfile.cmake Show resolved Hide resolved

fix last issue

9ef1894

Neumann-A commented Aug 7, 2020

View reviewed changes

ports/lapack-reference/CONTROL Show resolved Hide resolved

Neumann-A marked this pull request as ready for review August 7, 2020 14:34

Neumann-A added 7 commits August 7, 2020 17:57

depend on openblas

a9e0a17

set cmake_binary_dir so that compiler id run gets put into buildtree.

da34b28

more paths

dc17471

add missing PARENT_SCOPE

fa569bc

ws change

61708ad

[mlpack] remove dep on clapack

7eb3e03

comment out patches

d8a31b8

Neumann-A added 2 commits August 7, 2020 20:51

remove openblas again

66261d7

Install lapack wrapper since it is missing linkage against -lm and -l…

3b357f4

…gfortran

Neumann-A added 2 commits August 7, 2020 22:10

PREPEND mingw path to make sure cmake picks it up correctly

fdfb8c6

depend on openblas also on osx

7f78674

Neumann-A added 5 commits August 8, 2020 00:54

add clapack to skip on linux

4460b33

add -fPIC as a fortran compiler flag

6239ba9

do not add the flag on windows

0fa6f86

add gcc explicitly to the cmake args.

147e01e

ws change

5e40b0a

PhoebeHui assigned NancyLi1013 and JackBoosY Aug 10, 2020

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 10, 2020

NancyLi1013 suggested changes Aug 10, 2020

View reviewed changes

NancyLi1013 added the requires:author-response label Aug 10, 2020

JackBoosY suggested changes Aug 10, 2020

View reviewed changes

ports/mlpack/cmakelists.patch Outdated Show resolved Hide resolved

scripts/ci.baseline.txt Show resolved Hide resolved

Neumann-A added 2 commits August 10, 2020 14:35

applyrequested changes from CR

9c2641d

fix the failing patch

3887876

JackBoosY approved these changes Aug 11, 2020

View reviewed changes

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 11, 2020

strega-nil merged commit f3b96f3 into microsoft:master Aug 12, 2020

FishHe mentioned this pull request Aug 13, 2020

[lapack] build failure #12888

Closed

Neumann-A deleted the new_lapack_pr branch August 13, 2020 21:02

traversaro mentioned this pull request Aug 21, 2020

Fortran support #485

Closed

JackBoosY mentioned this pull request Aug 26, 2020

[baseline] Skip check of clapack:x64-osx in the baseline #13148

Merged

NancyLi1013 mentioned this pull request Apr 15, 2021

[lapack-reference] build failure - gfortran required? #17293

Closed

JackBoosY reviewed Aug 17, 2021

View reviewed changes

JackBoosY mentioned this pull request Aug 17, 2021

[vcpkg baseline] Re-fix lapack-reference to find blas on windows-static #19608

Closed

dg0yt reviewed Jan 2, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lapack-reference|fortran] Add new port #12805

[lapack-reference|fortran] Add new port #12805

Neumann-A commented Aug 7, 2020 •

edited

Loading

Neumann-A commented Aug 7, 2020

Neumann-A commented Aug 7, 2020 •

edited

Loading

centi commented Aug 7, 2020

Neumann-A commented Aug 7, 2020

cenit commented Aug 7, 2020

Neumann-A commented Aug 8, 2020

strega-nil commented Aug 12, 2020

janholt commented Aug 21, 2020

JackBoosY Aug 17, 2021

cenit Aug 17, 2021

Neumann-A Aug 17, 2021

dg0yt Jan 2, 2023

Neumann-A Jan 2, 2023

dg0yt Jan 2, 2023

Neumann-A Jan 2, 2023

Requested features	Static CRT & internal Fortran	Otherwise	Dependencies
core	-	`OPTIMIZED_BLAS`	none
cblas	`CBLAS`	`CBLAS`, `OPTIMIZED_BLAS`	none
noblas	-	`OPTIMIZED_BLAS`	`blas` (->`openblas`)
cblas,noblas	error	error	`blas` (->`openblas`)

[lapack-reference|fortran] Add new port #12805

[lapack-reference|fortran] Add new port #12805

Conversation

Neumann-A commented Aug 7, 2020 • edited Loading

Neumann-A commented Aug 7, 2020

Neumann-A commented Aug 7, 2020 • edited Loading

centi commented Aug 7, 2020

Neumann-A commented Aug 7, 2020

cenit commented Aug 7, 2020

Neumann-A commented Aug 8, 2020

strega-nil commented Aug 12, 2020

janholt commented Aug 21, 2020

JackBoosY Aug 17, 2021

Choose a reason for hiding this comment

cenit Aug 17, 2021

Choose a reason for hiding this comment

Neumann-A Aug 17, 2021

Choose a reason for hiding this comment

dg0yt Jan 2, 2023

Choose a reason for hiding this comment

Neumann-A Jan 2, 2023

Choose a reason for hiding this comment

dg0yt Jan 2, 2023

Choose a reason for hiding this comment

Neumann-A Jan 2, 2023

Choose a reason for hiding this comment

Neumann-A commented Aug 7, 2020 •

edited

Loading

Neumann-A commented Aug 7, 2020 •

edited

Loading