Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sleepy-discord] fix [core] build #20372

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

autoantwort
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/sleepy-discord/portfile.cmake

@autoantwort autoantwort force-pushed the sleepy-discord-fix-core branch from 5dfd392 to 4e66c94 Compare September 26, 2021 22:27
@PhoebeHui PhoebeHui self-assigned this Sep 27, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! what issue does this PR fix?

ports/sleepy-discord/portfile.cmake Show resolved Hide resolved
ports/sleepy-discord/portfile.cmake Show resolved Hide resolved
@autoantwort
Copy link
Contributor Author

Thanks for the PR! what issue does this PR fix?

As the title states, the sleepy-discord[core] build

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 27, 2021
@BillyONeal
Copy link
Member

Indeed, upstream always assumes that it can use asio, https://github.com/yourWaifu/sleepy-discord/blob/0f090ffc883dd7f0212969c5bed9c2b1699b2a38/sleepy_discord/CMakeLists.txt#L2 adds asio_udp unconditionally.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2021
@BillyONeal BillyONeal merged commit eb9d024 into microsoft:master Sep 29, 2021
@BillyONeal
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants