From 9523422eba51ec8b2efae24dbc00e19efd8aceb6 Mon Sep 17 00:00:00 2001 From: Xinyu Sui Date: Mon, 26 Jul 2021 16:52:46 -0700 Subject: [PATCH 1/2] Wrong logic for --no-warn-unused-cli --- src/preset.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/preset.ts b/src/preset.ts index ae5988a88..674d205eb 100644 --- a/src/preset.ts +++ b/src/preset.ts @@ -1244,7 +1244,7 @@ export function configureArgs(preset: ConfigurePreset): string[] { } preset.warnings.uninitialized && result.push('--warn-uninitialized'); - preset.warnings.unusedCli && result.push('--no-warn-unused-cli'); + !preset.warnings.unusedCli && result.push('--no-warn-unused-cli'); preset.warnings.systemVars && result.push('--check-system-vars'); } From 1bb9146ab25b97624649cfe1bab8ad6218e07321 Mon Sep 17 00:00:00 2001 From: Xinyu Sui Date: Mon, 26 Jul 2021 17:14:43 -0700 Subject: [PATCH 2/2] Check false --- src/preset.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/preset.ts b/src/preset.ts index 674d205eb..a0e504922 100644 --- a/src/preset.ts +++ b/src/preset.ts @@ -1244,7 +1244,7 @@ export function configureArgs(preset: ConfigurePreset): string[] { } preset.warnings.uninitialized && result.push('--warn-uninitialized'); - !preset.warnings.unusedCli && result.push('--no-warn-unused-cli'); + preset.warnings.unusedCli === false && result.push('--no-warn-unused-cli'); preset.warnings.systemVars && result.push('--check-system-vars'); } @@ -1307,8 +1307,8 @@ export function testArgs(preset: TestPreset): string[] { preset.output.outputOnFailure && result.push('--output-on-failure'); preset.output.quiet && result.push('--quiet'); preset.output.outputLogFile && result.push('--output-log', preset.output.outputLogFile); - !preset.output.labelSummary && result.push('--no-label-summary'); - !preset.output.subprojectSummary && result.push('--no-subproject-summary'); + preset.output.labelSummary === false && result.push('--no-label-summary'); + preset.output.subprojectSummary === false && result.push('--no-subproject-summary'); preset.output.maxPassedTestOutputSize && result.push('--test-output-size-passed', preset.output.maxPassedTestOutputSize.toString()); preset.output.maxFailedTestOutputSize && result.push('--test-output-size-failed', preset.output.maxFailedTestOutputSize.toString()); preset.output.maxTestNameWidth && result.push('--max-width', preset.output.maxTestNameWidth.toString()); @@ -1346,7 +1346,8 @@ export function testArgs(preset: TestPreset): string[] { preset.execution.testLoad && result.push('--test-load', preset.execution.testLoad.toString()); preset.execution.showOnly && result.push('--show-only', preset.execution.showOnly); preset.execution.repeat && result.push(`--repeat ${preset.execution.repeat.mode}:${preset.execution.repeat.count}`); - result.push(`--interactive-debug-mode ${preset.execution.interactiveDebugging ? 1 : 0}`); + preset.execution.interactiveDebugging && result.push('--interactive-debug-mode 1'); + preset.execution.interactiveDebugging === false && result.push('--interactive-debug-mode 0'); preset.execution.scheduleRandom && result.push('--schedule-random'); preset.execution.timeout && result.push('--timeout', preset.execution.timeout.toString()); preset.execution.noTestsAction && preset.execution.noTestsAction !== 'default' && result.push('--no-tests=' + preset.execution.noTestsAction);