From ce06935b6d57bd61f8216d9e07978761b450ea45 Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Fri, 16 Dec 2022 14:59:22 +0100 Subject: [PATCH 1/2] Add default status text. --- client/src/client.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/client.ts b/client/src/client.ts index 8957f9e9..5579212a 100644 --- a/client/src/client.ts +++ b/client/src/client.ts @@ -832,14 +832,14 @@ export namespace ESLintClient { let severity: LanguageStatusSeverity = LanguageStatusSeverity.Information; const [timeTaken, text, message, warnTime, errorTime] = function(): [number, string, string, number, number] { if (statusInfo.firstReport) { - return [-1, '', '', lintWarnTime, lintErrorTime]; + return [-1, 'ESLint', '', lintWarnTime, lintErrorTime]; } if ((statusInfo.fixTime ?? 0) > (statusInfo.validationTime ?? 0)) { return [statusInfo.fixTime ?? 0, `ESLint [${statusInfo.fixTime}ms]`, `Computing fixes during save for file ${uri} during save took ${statusInfo.fixTime}ms`, saveAllWarnTime, saveAllErrorTime]; } else if ((statusInfo.validationTime ?? 0) > 0) { return [statusInfo.validationTime ?? 0, `ESLint [${statusInfo.validationTime}ms]`, `Linting file ${uri} took ${statusInfo.validationTime}ms`, lintWarnTime, lintErrorTime]; } - return [-1, '', '', lintWarnTime, lintErrorTime]; + return [-1, 'ESLint', '', lintWarnTime, lintErrorTime]; }(); switch (statusInfo.state) { From b63a4433b4b5ccfa5f79fa48010552fd4f2e6dd7 Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Fri, 16 Dec 2022 15:05:01 +0100 Subject: [PATCH 2/2] Remove alwaysShowStatus setting --- README.md | 3 ++- package.json | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 538798a9..da8614b9 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,8 @@ From version 2.2.3 on forward odd major, minor or patch version numbers indicate ### Version 2.3.1 - Pre-release - the extension uses now VS Code's language status indicator -- the language status indicator now informs about long linting or fix on save times. Times above 750ms produce an error indication and times above 250ms a warning indication. +- the language status indicator now informs about long linting or fix on save times. +- the setting `eslint.alwaysShowStatus` got removed since the status is now shown as a language status indicator. ### Version 2.3.0 - Pre-release diff --git a/package.json b/package.json index c3c688cd..c782f997 100644 --- a/package.json +++ b/package.json @@ -65,12 +65,6 @@ "default": "npm", "description": "The package manager you use to install node modules." }, - "eslint.alwaysShowStatus": { - "type": "boolean", - "default": false, - "description": "Always show the ESlint status bar item.", - "scope": "window" - }, "eslint.problems.shortenToSingleLine": { "type": "boolean", "default": false,