From 6d1bf5c7999d5af0adcc15141ca012c34a9ca71c Mon Sep 17 00:00:00 2001 From: Hyang-Ah Hana Kim Date: Sun, 15 Mar 2020 23:35:24 -0400 Subject: [PATCH] Include the link to release note/package overview in the update prompt, and update gopls default version (#3041) --- src/goInstallTools.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts index bbe06d3b8..9c9071438 100644 --- a/src/goInstallTools.ts +++ b/src/goInstallTools.ts @@ -361,11 +361,18 @@ export async function promptForUpdatingTool(toolName: string) { } const goVersion = await getGoVersion(); const updateMsg = `Your version of ${tool.name} appears to be out of date. Please update for an improved experience.`; - vscode.window.showInformationMessage(updateMsg, 'Update').then((selected) => { + const choices: string[] = ['Update']; + if (toolName === `gopls`) { + choices.push('Release Notes'); // TODO(hyangah): pass more info such as version, release note location. + } + vscode.window.showInformationMessage(updateMsg, ...choices).then((selected) => { switch (selected) { case 'Update': installTools([tool], goVersion); break; + case 'Release Notes': + vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://github.com/golang/go/issues/33030#issuecomment-510151934')); + break; default: declinedUpdates.push(tool); break;