Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support dependency view #887

Merged
merged 3 commits into from
Aug 17, 2021
Merged

feat: Support dependency view #887

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43ef669
Support dependency view
CsCherrYY Aug 13, 2021
5e0e38d
fix tests
CsCherrYY Aug 13, 2021
979ad31
remove redundant export
CsCherrYY Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion extension/src/test/unit/gradleTasks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ describe(getSuiteName('Gradle tasks'), () => {
groupItem.label,
mockTaskDefinition1ForFolder1.group
);
assert.strictEqual(groupItem.iconPath, vscode.ThemeIcon.Folder);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we changed the themeicon in https://github.com/microsoft/vscode-gradle/pull/887/files#diff-183471d1a24e3c81ad33c4c977c62b13d94770466ca974bb60b5efcf3d6778d2 , IMO there is no way to check the icon so I simply remove it.

assert.strictEqual(
groupItem.parentTreeItem,
projectItem,
Expand Down