From e045beabb241b44d116f975d2d3961faebaf45af Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Mon, 6 Jun 2022 12:45:01 +0200 Subject: [PATCH] fix: errors thrown in process tree lookup not being visible Fixes #150754 --- CHANGELOG.md | 4 ++++ src/ui/processPicker.ts | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96226042c..755b11e95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes here may be available in the [nightly release](https://github.com/microsoft/vscode-js-debug/#nightly-extension) before they're in stable. Note that the minor version (`v1.X.0`) corresponds to the VS Code version js-debug is shipped in, but the patch version (`v1.50.X`) is not meaningful. +## Nightly (only) + +- fix: errors thrown in process tree lookup not being visible ([vscode#150754](https://github.com/microsoft/vscode/issues/150754)) + ## v1.68 (May 2022) ### v1.68.0 - 2022-05-30 diff --git a/src/ui/processPicker.ts b/src/ui/processPicker.ts index 659f3f8f8..b88a5c82e 100644 --- a/src/ui/processPicker.ts +++ b/src/ui/processPicker.ts @@ -194,7 +194,11 @@ async function listProcesses(): Promise { quickPick.items = acc; return acc; }, []) - .then(() => (quickPick.busy = false)); + .then(() => (quickPick.busy = false)) + .catch(err => { + vscode.window.showErrorMessage(`Error listing processes: ${err.message}`); + quickPick.dispose(); + }); const item = await itemPromise; hasPicked = true;