-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel crashes due to upstream problems with zmq package (seen with usage of bokeh and similar packages) #10386
Comments
@uwezi Thanks for the report here. I actually repro the same thing. Checking into it now. I see this as the possible first error in the developer tools.
Not sure on the cause yet, but does seem to be coming from the Jupyter extension. |
Looks like an out of memory error. I wonder if we're keeping messages for ipywidgets in memory by mistake. Might this be related to the work that Don was doing? |
@IanMatthewHuff that looks like something that'll crash the node runtime (native node modules can bring down the extension host, in this case we're bringing down the entire VS Code UI) - think somehow our native modules are getting loaded in a context that it shouldn't. |
Should test an older version of VS Code, could be due to a change in vscode (version of node shipped with VS Code). |
Which changes, I don't think I'm caching anything, can't remember, would like to look into it. |
The code were we were not disposing of widgets correctly. Maybe that was in the renderer though. |
We should try this again with Don's new changes. |
This problem only occurs in the desktop ZMQ version. Works fine in web and remote and with ZMQ disabled. Workaround then is to set this hidden setting (or use remote):
|
As an un-initiated user: where would I find this hidden setting? |
You can just type it into your global settings.json. The schema validation won't recognize it, but it will still allow you to type it. |
Did some more investigation. This is a bug in ZMQ 6. If I switch our code to ZMQ 5, the problem goes away. I think we have two choices:
|
ZMQ 5 of our source is here: |
Ack, that's sticky... NAPI support was our big reason for moving to ZMQ6. Electron-rebuild works for dev work, but I'm not even sure how we'd ship ZMQ5. VS Code versions update node as needed, extension can't just support a specific single version. I should look and see how others are dealing with this. |
Perhaps we can rebuild the ZMQ5 code to use NAPI. Although seems easier to just fix the bug in 6 version. |
Per the versions it honestly looks like ZMQ6 might be abandoned? Looks like it stalled out a years ago. Readme and guide pushed 6.0 for new projects, but it last released in 2019. |
I think we might become the owners or next to update it then. @DonJayamanne is actually going to be building new bits for M1 support for ZMQ 6 based on the latest feedback on this: |
Here's the callstack of the exit process:
|
Ipyvolume and fileupload also crash this way. |
The problem persists in VS Code 1.68.1 |
Related to this (closed) issue, which was not reproducible: |
Problem still exists in VS Code 1.72.2. Trying to upload a file using |
This workaround appears to no longer work? When I enable this setting and run my notebook, I get the following error:
|
Could you try the latest beta version of zeromq to see if the issue is resolved? |
Disabling ZMQ support fix works for me with VS Code version 1.77.3 using Windows. |
Closing this issue as this hasn't been reported for a while. |
Environment data
Expected behaviour
flawless execution of example notebook from bqplot
Actual behaviour
crashing of the IDE
Steps to reproduce:
download "interaction layer.ipynb" from https://github.com/bqplot/bqplot/tree/master/examples/Interactions
Logs
Issue Type: Bug
Opening an example script file for the bqplot library, such as "Interaction Layer.ipynb" from https://github.com/bqplot/bqplot/tree/master/examples/Interactions
worked fine in the previous release of VSCode. Since upgrading on both my computer to the latest VSCode-release (April 2022) the script somehow crashes the IDE. When running the script, operation suddenly ceases and a prompt asks to save changes in the notebook file. Afterwards cell contents has been disappearing.
No change in the script files, nor in the python installation has been done simultaneously. Only change was the update of VSCode.
I observed this first yesterday on my stationary computer, today also my laptop updated itself to the new version of VSCode and now this behavior is persistent on both systems. Reinstallation of the jupyter-extension didn't help.
Extension version: 2022.4.1021342353
VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:15:52.058Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: