Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review API JupyterServerProvider and prepare for stable API #13894

Closed
1 task done
rebornix opened this issue Jul 10, 2023 · 3 comments
Closed
1 task done

Review API JupyterServerProvider and prepare for stable API #13894

rebornix opened this issue Jul 10, 2023 · 3 comments
Assignees

Comments

@rebornix
Copy link
Member

rebornix commented Jul 10, 2023

This would be our exercise for our first stable API JupyterServerProvider

Tasks

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jul 10, 2023
@rebornix rebornix removed the bug Issue identified by VS Code Team member as probable bug label Jul 10, 2023
@DonJayamanne
Copy link
Contributor

This is where the discussions are taking place #14106

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Aug 28, 2023

API Discussion outcomes

  • Use CancellationError and return undefined to distinguish between cancel and back (see how done in VS code Kernels)
  • Commands is tricky
    • We would like to enforce a good UX (ensure 3rd party extension have back button etc)
    • The command API is very much tied to the UI

@DonJayamanne
Copy link
Contributor

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants