Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes to Proposed API and Trusted Notebooks #5109

Closed
DonJayamanne opened this issue Mar 11, 2021 · 1 comment
Closed

Review changes to Proposed API and Trusted Notebooks #5109

DonJayamanne opened this issue Mar 11, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 11, 2021

The concept of trusting notebooks has changed in the API

  • Review the current proposed API (changes)
  • Review the new proposed API (what's the proposed solution for enabling trust in notebooks?)
  • Remove redundant code (tests, changing metadata to trusted, runnable, etc) - where applicable

Note: VSC hasn't decided on an API yet, track the progress here microsoft/vscode#118584

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 11, 2021
@greazer greazer added this to the April 2021 Release milestone Mar 24, 2021
@DonJayamanne
Copy link
Contributor Author

Closing for now, as there's nothing to be done. We have reviewed the issue and provided feedback.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants