Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on the vscode-interactive schema for IW resources #13447

Merged
merged 5 commits into from
May 3, 2023

Conversation

amunger
Copy link
Contributor

@amunger amunger commented May 3, 2023

necessary if we are going to use untitled resources for IW in microsoft/vscode#172974

including @debonte because of the change to getNotebookUriFromInputBoxUri, let me know if there's something I should be testing against that change.

@amunger amunger force-pushed the aamunger/IWSchema branch from bed9006 to d64e9fc Compare May 3, 2023 20:05
@amunger amunger marked this pull request as ready for review May 3, 2023 20:23
@amunger amunger merged commit 7b9b203 into main May 3, 2023
@amunger amunger deleted the aamunger/IWSchema branch May 3, 2023 21:26
@debonte
Copy link
Contributor

debonte commented May 3, 2023

let me know if there's something I should be testing against that change.

@amunger, given this executed cell:

existingVar = 1

Please verify:

  1. When you type exist in the input box, you get existingVar as a completion suggestion.
  2. After accepting that suggestion, ensure that your usage of existingVar (in the input box, before execution) does not have a red squiggle indicating that it is unknown / not defined.

I think that should be sufficient to verify that Pylance, Python, and Jupyter are all working together to make the IW inbox box look like a notebook cell in LSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants