Support for multi-location diagnostics #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2018
Merged
rcjsuen
reviewed
Mar 21, 2018
protocol/src/protocol.ts
Outdated
| /** | ||
| * Whether the client supports diagnostics with related information. | ||
| */ | ||
| diagnosticRelatedInformation?: boolean; |
There was a problem hiding this comment.
I don't think that this property belongs here. Since diagnostics are in the form of a textDocument/publishDiagnostics request, perhaps it should go there instead?
There was a problem hiding this comment.
Makes sense. I moved the capability. Thanks!
|
@kieferrm merge the PR, but didn't publish yet. Will wait for the 1.22 release. I also updated the specification :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for multi-location diagnostics.
I used https://github.com/kieferrm/lsp-dev-setup to setup the experimentation environment.