Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Copy Permalink as Markdown share provider #4886

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Implement Copy Permalink as Markdown share provider #4886

merged 1 commit into from
Jun 9, 2023

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl requested a review from alexr00 June 2, 2023 21:33
alexr00
alexr00 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This still doesn't surface anywhere, correct?

@joyceerhl
Copy link
Contributor Author

@alexr00 it's hidden by default but surfaces in the command palette when you enable "workbench.experimental.share.enabled": true and also next to the command center when you enable "window.commandCenter": true.

@alexr00
Copy link
Member

alexr00 commented Jun 9, 2023

@joyceerhl the 0.66.0 release has happened. It is ok to merge this when you're ready!

@joyceerhl
Copy link
Contributor Author

Thank you @alexr00!

@joyceerhl joyceerhl merged commit a3d2482 into main Jun 9, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/electoral-spoonbill branch June 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joyceerhl @alexr00