Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python extension should not register 'python' debugger in web #530

Open
sbatten opened this issue Nov 29, 2022 · 8 comments
Open

Python extension should not register 'python' debugger in web #530

sbatten opened this issue Nov 29, 2022 · 8 comments
Assignees
Labels
needs PR Ready to be worked on

Comments

@sbatten
Copy link
Member

sbatten commented Nov 29, 2022

Testing microsoft/vscode#167433

insiders.vscode.dev

image

@joyceerhl
Copy link

Given we now do support debugging in the web with microsoft/vscode#167399, I think the debug welcome view is never going to show up...or could the fact that the debug view is always populated now be related to workspace trust changes for web?

@sbatten
Copy link
Member Author

sbatten commented Nov 30, 2022

There are no recent changes to workspace trust in the web that I am aware of, but it could be that we just assumed debugging is available now. It seems wrong for this case because I have launch configs, but they will not work as they require a different debug adapter.

@joyceerhl
Copy link

@connor4312 do you happen to have context on why the debug view is populated with launch configs in web now and not before?

@connor4312
Copy link
Member

connor4312 commented Nov 30, 2022

The debug view is shown if there's at least one installed extension that registers a debugger. It looks like (one of) the Python extensions now does this--just testing by seeing what completions are available for type in a launch.json.

image

@joyceerhl
Copy link

Ah, that'll be the experimental Python WASM extension, that makes sense. Also confirmed that if I uninstall that extension the welcome view reappears. @sbatten do you have that extension installed, and if you uninstall it does the debug view show up for you?

@sbatten
Copy link
Member Author

sbatten commented Nov 30, 2022

I don't but it's actually coming from the main python extension. I disable that and get the welcome view. So as far as continue working on... this is working.

@joyceerhl
Copy link

@paulacamargo25 does the Python extension contribute a debugger that works in web, and if it does not, can we ensure not to register it in web?

@paulacamargo25
Copy link
Contributor

@joyceerhl No, our debugger doesn't work on the web, I check and we already show a message, that python configuration is not supported.

Screenshot 2022-11-30 at 11 17 25 AM

I'll check if it's possible not to register it at all.

@joyceerhl joyceerhl transferred this issue from microsoft/vscode Nov 30, 2022
@joyceerhl joyceerhl changed the title Debug view is not the welcome view, so I see no continue on... Python extension should not register 'python' debugger in web Nov 30, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 30, 2022
@paulacamargo25 paulacamargo25 self-assigned this Nov 30, 2022
@paulacamargo25 paulacamargo25 added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Dec 1, 2022
@eleanorjboyd eleanorjboyd transferred this issue from microsoft/vscode-python Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

5 participants