Update micro build number #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
requested changes
Apr 20, 2024
paulacamargo25
force-pushed
the
Update-micro-build-number
branch
from
016c53b to
53bd85e
Compare
paulacamargo25
requested review from
karthiknadig
and removed request for
karthiknadig
build/update_ext_version.py
Outdated
| """ | ||
| return f"1{datetime.datetime.now(tz=datetime.timezone.utc).strftime('%j%H%M')}" | ||
| return f"{datetime.datetime.now(tz=datetime.timezone.utc).strftime('%y%j')}.{os.environ.get("REV", "")}" |
There was a problem hiding this comment.
I think we can just do Julian day and rev. Since we already capture year for major.
paulacamargo25
force-pushed
the
Update-micro-build-number
branch
from
5028363 to
f6778b3
Compare
karthiknadig
reviewed
Jun 7, 2024
build/update_ext_version.py
Outdated
| @@ -45,9 +46,9 @@ def is_even(v: Union[int, str]) -> bool: | |||
|
|
|||
| def micro_build_number() -> str: | |||
| """Generates the micro build number. | |||
| The format is `1<Julian day><hour><minute>`. | |||
| The format is `<Year><Julian day><REV>`. | |||
There was a problem hiding this comment.
Since the version major is the year do we the full year. I think just YYJJJREV should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update micro build number to use day, month and year.
Closed: #290