Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiroot workspaces with the VS Analysis Engine #1149

Closed
MikhailArkhipov opened this issue Mar 21, 2018 · 3 comments
Closed

Support multiroot workspaces with the VS Analysis Engine #1149

MikhailArkhipov opened this issue Mar 21, 2018 · 3 comments
Labels
feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@MikhailArkhipov
Copy link

How does this analysis engine work with a multi root workspace?
E.g. workspace folder A & B contain two separate versions of Python.
Will we have only one analysis engine or two, will they all use the same version of python?

So far VS project has same interpreter. But not per folder. However, solution can have multiple projects with different interpreters.

@MikhailArkhipov MikhailArkhipov added feature-request Request for new features or functionality needs PR labels Mar 21, 2018
@MikhailArkhipov MikhailArkhipov added this to the April 2018 milestone Mar 21, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Mar 21, 2018
@MikhailArkhipov
Copy link
Author

VSC can automatically run multiple language servers (one per workspace root). Just need to verify.

@MikhailArkhipov MikhailArkhipov modified the milestones: April 2018, May 2018 Apr 19, 2018
@MikhailArkhipov MikhailArkhipov modified the milestones: May 2018, June 2018 May 23, 2018
@brettcannon brettcannon removed this from the June 2018 milestone Jun 4, 2018
@DonJayamanne DonJayamanne changed the title Figure out how to handle multiroot workspace with the VS Analysis Engine Support multiroot workspaces with the VS Analysis Engine Oct 9, 2018
@brettcannon brettcannon added needs proposal Need to make some design decisions and removed needs PR labels Oct 24, 2018
@DonJayamanne
Copy link

DonJayamanne commented Oct 24, 2018

Based on my initial investigation this is most certainly possible within the Extension.
Lazy load instances for the workspaces, instead of loading multiple instances for each workspace folder in a multiroot workspace.

@brettcannon
Copy link
Member

This should only lazily load an instance of the language server based on whether a workspace has actually opened a Python file (and set the interpreter).

@lock lock bot locked as resolved and limited conversation to collaborators Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

3 participants