Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'LogPoints' in debugger #1306

Closed
DonJayamanne opened this issue Apr 5, 2018 · 4 comments · Fixed by #1406
Closed

Add support for 'LogPoints' in debugger #1306

DonJayamanne opened this issue Apr 5, 2018 · 4 comments · Fixed by #1406
Assignees
@DonJayamanne
Labels
area-debugging feature-request Request for new features or functionality
Milestone
May 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 5, 2018 •
edited
Loading

PTVS has this today, they call it Trace Points (hence functionality should be available in the new version of PTVSD).

Requires upstream changes as well #1306
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR area-debugging labels Apr 5, 2018
@qubitron
Copy link

qubitron commented Apr 5, 2018

FYI this is currently planned for the March release for VS Code, microsoft/vscode#45128, but it might be at preview quality.

@DonJayamanne
Copy link
Author

but it might be at preview quality.

Is this based on the issues/feedback on VS Code github repo?

@qubitron
Copy link

qubitron commented Apr 6, 2018

Per Kenneth's last comment in the upstream issue, he had some concerns with readiness.

@qubitron qubitron added this to the May 2018 milestone Apr 12, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 16, 2018
@DonJayamanne
Copy link
Author

@qubitron
I've managed to get this working in PTVSD (microsoft/ptvsd#350).
I think we can land this feature as well.

@DonJayamanne DonJayamanne mentioned this issue Apr 17, 2018
Merged
4 tasks
DonJayamanne added a commit that referenced this issue Apr 17, 2018
@DonJayamanne
Add support for log points
41ec24a 
Fixes #1306
@DonJayamanne DonJayamanne mentioned this issue May 8, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Add support for log points DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @qubitron