-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a notebook for the first time shows Python core notifications that don't apply to notebooks #13437
Comments
Thanks for the issue @misolori. The survey should stop appearing if you click 'No, thanks'. And if you only use secure sources or create your own notebooks you can remove the trust notification with the setting 'Python › Data Science: Always Trust Notebooks'. We'll discuss the issue in an upcoming meeting, but let me know if that is good enough. |
I understand that there are ways to dismiss some of those notifications, my point was that there is a lot of noise on your first experience. It’s like being greeted by 4 people telling you 4 different things at the same time. For example: why not show the survey after some time? Why not show the trust notebook notification when you attempt to run a cell? Delaying these will significantly improve the experience. |
Definitely agree on the survey. And the trust notebook is a good idea, I'll make sure to go over it on the meeting. |
Thanks for the feedback! Few things. First, a user will not receive the survey on first opening of a notebook. Second, we must show the Trust popup. We can't wait for the user to press Run because the user may just want to see the outputs. The third and fourth problems are in the core Python code. So I'm going to tag this for them to see. |
Duplicate of #7700 |
Environment data
python.languageServer
setting: JediExpected behaviour
I get that I need to have some things appear for things to work, but we should do it in a graceful way.
Actual behaviour
Multiple notifications appear at the same time:
Steps to reproduce:
.ipynb
fileThe text was updated successfully, but these errors were encountered: