Conda environment unclear dialog actions

[mmv]

Issue Type: Bug

Behaviour

Expected vs. Actual

I open a directory with a venv supported by conda. A dialog appears with the following message:

We noticed you're using a conda environment. If you are experiencing issues with this envrionment in the integrat3ed terminal, we recommend that you let the Python extension change "terminal.integrated.inheritEnv" to false in your user settings.

The dialog contains 3 action options: Yes, No and More Info.

Since there's no question in the dialog, it's not clear what answering Yes or No would do.

Steps to reproduce:

1. open a directory with a venv supported by conda

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.8.13
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
• Value of the python.languageServer setting: Default

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.4.1
VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:46:01.075Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-1061-aws

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.73GB (3.22GB free)
Process Argv	--folder-uri vscode-remote://ssh-remote%2Baws--mmv-model-train/home/ubuntu/work/kubeflow --crash-reporter-id c3df0df3-5f8b-4ada-9b57-6ee2224b0c49
Screen Reader	no
VM	0%

Item	Value
Remote	SSH: aws--mmv-model-train
OS	Linux x64 5.4.0-1061-aws
CPUs	AMD EPYC 7571 (32 x 2548)
Memory (System)	123.69GB (94.30GB free)
VM	0%

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebugcf:30475217

[karthiknadig]

Thanks for the feedback. It is indeed unclear on what action yes or no leads to.

[karthiknadig]

@luabud We have plans to remove this notification eventually. But until then this is what each of the buttons actually do:

• yes: Adds "terminal.integrated.inheritEnv": false to the global setting.
• no: No setting change but disables the prompt.
• more info: Open this link https://aka.ms/AA66i8f

I think we need to change the text to let users know what yes or no will do.