Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is a Pipfile or .python-version file, trigger discovery when autoselecting #23139

Closed
2 tasks
karrtikr opened this issue Mar 27, 2024 · 4 comments
Closed
2 tasks
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented Mar 27, 2024

THIS ISSUE MAY NOT BE NEEDED ONCE WE HAVE WORKFLOW EXTENSIONS MANAGING THEIR OWN ENVS: #22836

When opening a new workspace, before auto-selecting begins:

  • If there is a Pipfile, make sure to trigger Pipenv discovery:
  • If there is a .python-version file, make sure to trigger Pyenv discovery

This is where we should do it:

await this.interpreterService.triggerRefresh({
searchLocations: { roots: [resource], doNotIncludeNonRooted: true },
});

@LoganB99

This comment was marked as resolved.

@LoganB99

This comment was marked as resolved.

@eleanorjboyd
Copy link
Member

@karthiknadig - curious if you think this is still necessary or no longer in scope

@karthiknadig
Copy link
Member

No longer i scope. If users contribute an extension for pipenv or pyenv, they can control this there.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants