Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create functional tests to ensure extension load is not blocked by prompts #7703

Closed
DonJayamanne opened this issue Oct 1, 2019 · 1 comment
Closed

Create functional tests to ensure extension load is not blocked by prompts #7703

DonJayamanne opened this issue Oct 1, 2019 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Oct 1, 2019 •
edited
Loading

When extension loads we can display messages as part of the IExtensionActivationService.activate method.
This will prevent extension from loading.

Solution: Add tests to ensure the active methods do not block as a result of prompts.
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 1, 2019
@DonJayamanne DonJayamanne self-assigned this Oct 1, 2019
@DonJayamanne DonJayamanne mentioned this issue Oct 1, 2019
Closed
@DonJayamanne DonJayamanne removed their assignment Oct 1, 2019
@brettcannon brettcannon removed the xteam label Nov 26, 2020
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link

Closing as stale as we no longer show start up prompts.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @karrtikr