Log env info when the existence of pipenv cannot be determined #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3r3kk
approved these changes
Jun 14, 2018
| const platformService = this.serviceContainer.get<IPlatformService>(IPlatformService); | ||
| const currentProc = this.serviceContainer.get<ICurrentProcess>(ICurrentProcess); | ||
| const enviromentVariableValues = { | ||
| LC_ALL: currentProc.env.LC_ALL, |
There was a problem hiding this comment.
Are these variables defined in the Windows environment? I'm used to seeing them in Linux (and presume that macOS shares these), but I don't remember seeing them in Windows...
There was a problem hiding this comment.
Documented here http://click.pocoo.org/5/python3
Required by one of the dependencies of pipenv
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338
This pull request: